[GitHub] nitin-maharana commented on issue #2130: CLOUDSTACK-8961: Changes related to the UI of VPN Users management.

2017-06-18 Thread git
nitin-maharana commented on issue #2130: CLOUDSTACK-8961: Changes related to the UI of VPN Users management. URL: https://github.com/apache/cloudstack/pull/2130#issuecomment-309264874 Hi @remibergsma, After a long time. How's everything. Thanks for reviewing it. Now, combined both the comm

[GitHub] nitin-maharana commented on issue #2130: CLOUDSTACK-8961: Changes related to the UI of VPN Users management.

2017-06-18 Thread git
nitin-maharana commented on issue #2130: CLOUDSTACK-8961: Changes related to the UI of VPN Users management. URL: https://github.com/apache/cloudstack/pull/2130#issuecomment-309264947 Ping @jayapalu @karuturi This is an aut

[GitHub] karuturi closed pull request #2089: vRouters fixes & performance improvement

2017-06-18 Thread git
karuturi closed pull request #2089: vRouters fixes & performance improvement URL: https://github.com/apache/cloudstack/pull/2089 This is an automated message from the Apache Git Service. To respond to the message, please log

[cloudstack] branch 4.9 updated (52232b9 -> dab9795)

2017-06-18 Thread rajani
This is an automated email from the ASF dual-hosted git repository. rajani pushed a change to branch 4.9 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 52232b9 Merge pull request #2135 from shapeblue/force-stop-vm-kvm add c10c324 vRouter: prevent fh leakage and

[cloudstack] 01/01: Merge pull request #2089 from The-Loeki/vrouter-defer-configure

2017-06-18 Thread rajani
This is an automated email from the ASF dual-hosted git repository. rajani pushed a commit to branch 4.9 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit dab9795bf4dba4fb5aea64933a5099eff0f29c8f Merge: 52232b9 330a0c7 Author: Rajani Karuturi AuthorDate: Sun Jun 18 14:47:10

[GitHub] rhtyd commented on issue #2129: CLOUDSTACK-9928: Allow native CloudStack users to change password in UI

2017-06-18 Thread git
rhtyd commented on issue #2129: CLOUDSTACK-9928: Allow native CloudStack users to change password in UI URL: https://github.com/apache/cloudstack/pull/2129#issuecomment-306699936 @karuturi fixed conflict, can you consider merging this thanks. --

[GitHub] rhtyd commented on issue #2129: CLOUDSTACK-9928: Allow native CloudStack users to change password in UI

2017-06-18 Thread git
rhtyd commented on issue #2129: CLOUDSTACK-9928: Allow native CloudStack users to change password in UI URL: https://github.com/apache/cloudstack/pull/2129#issuecomment-306097801 @karuturi can you help merge this? This is an

[GitHub] rhtyd commented on issue #2129: CLOUDSTACK-9928: Allow native CloudStack users to change password in UI

2017-06-18 Thread git
rhtyd commented on issue #2129: CLOUDSTACK-9928: Allow native CloudStack users to change password in UI URL: https://github.com/apache/cloudstack/pull/2129#issuecomment-309267047 @karuturi can you consider merging this? This

[GitHub] rhtyd commented on issue #2129: CLOUDSTACK-9928: Allow native CloudStack users to change password in UI

2017-06-18 Thread git
rhtyd commented on issue #2129: CLOUDSTACK-9928: Allow native CloudStack users to change password in UI URL: https://github.com/apache/cloudstack/pull/2129#issuecomment-306450249 @karuturi this is a UI/API fix, can you consider merging this? ---

[GitHub] nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-06-18 Thread git
nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack URL: https://github.com/apache/cloudstack/pull/2031#discussion_r122589538 ## File path: engine/schema/src/com/cloud/offerings/dao/NetworkOfferingDaoImpl.java ## @

[GitHub] nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-06-18 Thread git
nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack URL: https://github.com/apache/cloudstack/pull/2031#discussion_r122589608 ## File path: engine/schema/src/com/cloud/offerings/dao/NetworkOfferingDaoImpl.java ## @

[GitHub] nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-06-18 Thread git
nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack URL: https://github.com/apache/cloudstack/pull/2031#discussion_r122589635 ## File path: engine/components-api/src/com/cloud/network/IpAddressManager.java ## @@ -16

[GitHub] nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-06-18 Thread git
nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack URL: https://github.com/apache/cloudstack/pull/2031#discussion_r122589624 ## File path: api/src/org/apache/cloudstack/api/command/admin/address/AcquirePodIpCmdByAdmin.java

[GitHub] nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-06-18 Thread git
nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack URL: https://github.com/apache/cloudstack/pull/2031#discussion_r122589646 ## File path: server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java ## @@ -381,4 +381,10

[GitHub] nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-06-18 Thread git
nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack URL: https://github.com/apache/cloudstack/pull/2031#discussion_r122589667 ## File path: server/src/org/apache/cloudstack/network/ssl/CertServiceImpl.java ## @@ -32

[GitHub] nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-06-18 Thread git
nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack URL: https://github.com/apache/cloudstack/pull/2031#discussion_r122589684 ## File path: plugins/network-elements/netscaler/src/com/cloud/network/dao/NetScalerControlCenterD

[GitHub] nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-06-18 Thread git
nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack URL: https://github.com/apache/cloudstack/pull/2031#discussion_r122590361 ## File path: plugins/network-elements/netscaler/src/com/cloud/network/dao/NetScalerControlCenterD

[GitHub] nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-06-18 Thread git
nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack URL: https://github.com/apache/cloudstack/pull/2031#discussion_r122590359 ## File path: plugins/network-elements/netscaler/src/com/cloud/network/dao/NetScalerServicePackage

[GitHub] nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-06-18 Thread git
nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack URL: https://github.com/apache/cloudstack/pull/2031#discussion_r122590643 ## File path: api/src/org/apache/cloudstack/api/command/admin/address/AcquirePodIpCmdByAdmin.java

[GitHub] nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-06-18 Thread git
nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack URL: https://github.com/apache/cloudstack/pull/2031#discussion_r122590691 ## File path: core/src/com/cloud/agent/api/NetScalerImplementNetworkCommand.java ## @@ -0

[GitHub] nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-06-18 Thread git
nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack URL: https://github.com/apache/cloudstack/pull/2031#discussion_r122590743 ## File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ## @@

[GitHub] nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-06-18 Thread git
nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack URL: https://github.com/apache/cloudstack/pull/2031#discussion_r122590902 ## File path: setup/db/db/schema-4920to41000.sql ## @@ -234,3 +234,26 @@ WHERE (o.cpu is

[GitHub] nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-06-18 Thread git
nitin-maharana commented on a change in pull request #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack URL: https://github.com/apache/cloudstack/pull/2031#discussion_r122591220 ## File path: server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java ## @@ -2

[GitHub] nitin-maharana commented on issue #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-06-18 Thread git
nitin-maharana commented on issue #2031: CLOUDSTACK-8672 : NCC Integration with CloudStack URL: https://github.com/apache/cloudstack/pull/2031#issuecomment-309278352 Hi @rafaelweingartner, Please find my answers below each of your comments. Please let me know if those don't clarify.

[GitHub] karuturi commented on issue #2150: Two fixes for RC3 by @mike-tutkowski

2017-06-18 Thread git
karuturi commented on issue #2150: Two fixes for RC3 by @mike-tutkowski URL: https://github.com/apache/cloudstack/pull/2150#issuecomment-309337392 @borisstoyanov Can you give your review? We have one code LGTM from @anshul-gangwar on PR #2141 --

[GitHub] pavanaravapalli commented on a change in pull request #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state

2017-06-18 Thread git
pavanaravapalli commented on a change in pull request #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state URL: https://github.com/apache/cloudstack/pull/2149#discussion_r122630756 ## File path: server/src/com/cloud/storage/snapshot/SnapshotManagerImp