Re: [PR] UI: Allow custom footer in password reset page [cloudstack]

2025-03-06 Thread via GitHub
Pearl1594 merged PR #10461: URL: https://github.com/apache/cloudstack/pull/10461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@clo

Re: [PR] UI: Allow custom footer in password reset page [cloudstack]

2025-03-06 Thread via GitHub
DaanHoogland commented on PR #10461: URL: https://github.com/apache/cloudstack/pull/10461#issuecomment-2703205130 @Pearl1594 can you have a look/merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] UI: Allow custom footer in password reset page [cloudstack]

2025-03-03 Thread via GitHub
vishesh92 commented on PR #10461: URL: https://github.com/apache/cloudstack/pull/10461#issuecomment-2696339603 > two issues @vishesh92 > > 1. after setting `loginFooter` no contents is shown anymor. not even a login dialog. (also not after removing the value from config.json again

Re: [PR] UI: Allow custom footer in password reset page [cloudstack]

2025-03-03 Thread via GitHub
blueorangutan commented on PR #10461: URL: https://github.com/apache/cloudstack/pull/10461#issuecomment-2695488925 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] UI: Allow custom footer in password reset page [cloudstack]

2025-03-03 Thread via GitHub
sonarqubecloud[bot] commented on PR #10461: URL: https://github.com/apache/cloudstack/pull/10461#issuecomment-2695432396 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https:/

Re: [PR] UI: Allow custom footer in password reset page [cloudstack]

2025-03-03 Thread via GitHub
blueorangutan commented on PR #10461: URL: https://github.com/apache/cloudstack/pull/10461#issuecomment-2695321141 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] UI: Allow custom footer in password reset page [cloudstack]

2025-03-03 Thread via GitHub
vishesh92 commented on PR #10461: URL: https://github.com/apache/cloudstack/pull/10461#issuecomment-2695318637 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] UI: Allow custom footer in password reset page [cloudstack]

2025-02-27 Thread via GitHub
DaanHoogland commented on PR #10461: URL: https://github.com/apache/cloudstack/pull/10461#issuecomment-2688113356 two issues @vishesh92 1. after setting `loginFooter` no contents is shown anymor. not even a login dialog. (also not after removing the value from config.json again 2. no

Re: [PR] UI: Allow custom footer in password reset page [cloudstack]

2025-02-26 Thread via GitHub
blueorangutan commented on PR #10461: URL: https://github.com/apache/cloudstack/pull/10461#issuecomment-2687023563 [SF] Trillian test result (tid-12498) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 53236 seconds Marvin logs: https://github.co

Re: [PR] UI: Allow custom footer in password reset page [cloudstack]

2025-02-26 Thread via GitHub
blueorangutan commented on PR #10461: URL: https://github.com/apache/cloudstack/pull/10461#issuecomment-2685226446 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] UI: Allow custom footer in password reset page [cloudstack]

2025-02-26 Thread via GitHub
DaanHoogland commented on code in PR #10461: URL: https://github.com/apache/cloudstack/pull/10461#discussion_r1971545926 ## ui/src/layouts/UserLayout.vue: ## @@ -37,8 +37,9 @@ - - + + + Review Comment: should this be ```sugg

Re: [PR] UI: Allow custom footer in password reset page [cloudstack]

2025-02-25 Thread via GitHub
sonarqubecloud[bot] commented on PR #10461: URL: https://github.com/apache/cloudstack/pull/10461#issuecomment-2681621107 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https:/

Re: [PR] UI: Allow custom footer in password reset page [cloudstack]

2025-02-25 Thread via GitHub
blueorangutan commented on PR #10461: URL: https://github.com/apache/cloudstack/pull/10461#issuecomment-2681532331 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10461 (QA-JID-560) -- This is an automated message from the Apache Git Service. To respon

Re: [PR] UI: Allow custom footer in password reset page [cloudstack]

2025-02-25 Thread via GitHub
codecov[bot] commented on PR #10461: URL: https://github.com/apache/cloudstack/pull/10461#issuecomment-2681494070 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10461?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

Re: [PR] UI: Allow custom footer in password reset page [cloudstack]

2025-02-25 Thread via GitHub
blueorangutan commented on PR #10461: URL: https://github.com/apache/cloudstack/pull/10461#issuecomment-2681478844 @vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] UI: Allow custom footer in password reset page [cloudstack]

2025-02-25 Thread via GitHub
vishesh92 commented on PR #10461: URL: https://github.com/apache/cloudstack/pull/10461#issuecomment-2681475339 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme