Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-07-11 Thread via GitHub
DaanHoogland merged PR #10504: URL: https://github.com/apache/cloudstack/pull/10504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-07-11 Thread via GitHub
boring-cyborg[bot] commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-3062325842 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-17 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2982304347 [SF] Trillian test result (tid-13539) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 62198 seconds Marvin logs: https://githu

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-17 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2979204131 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To res

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-17 Thread via GitHub
DaanHoogland commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2979200518 @blueorangutan test ol8 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-16 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2979051153 [SF] Trillian test result (tid-13538) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 58247 seconds Marvin logs: https://github.co

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-16 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2976542152 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-16 Thread via GitHub
DaanHoogland commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2976534918 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-16 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2975569838 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-16 Thread via GitHub
DaanHoogland commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2975337737 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-16 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2975338836 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-14 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2972607893 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-14 Thread via GitHub
sroopsai commented on code in PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#discussion_r2146786084 ## engine/orchestration/src/main/java/com/cloud/agent/manager/DirectAgentAttache.java: ## @@ -23,6 +23,7 @@ import java.util.concurrent.TimeUnit; import java.ut

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-14 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2972550269 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-14 Thread via GitHub
DaanHoogland commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2972549548 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-14 Thread via GitHub
DaanHoogland commented on code in PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#discussion_r2146773448 ## engine/orchestration/src/main/java/com/cloud/agent/manager/DirectAgentAttache.java: ## @@ -23,6 +23,7 @@ import java.util.concurrent.TimeUnit; import jav

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-13 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2971453393 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-13 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2971186517 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-13 Thread via GitHub
DaanHoogland commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2971180573 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-13 Thread via GitHub
github-actions[bot] commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2970424039 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-12 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2966780710 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-12 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2965589803 Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 13734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-12 Thread via GitHub
DaanHoogland commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2965296449 > Thank You for the suggestions @DaanHoogland > > 1. The other locations where sleep() is being called is in non-synchronised blocks, I think it is not good idea to replac

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-11 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2965301827 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-11 Thread via GitHub
DaanHoogland commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2965297716 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-11 Thread via GitHub
sroopsai commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2963180214 1. The other locations where sleep() is being called is in non-synchronised blocks, I think it is not good idea to replace those sleep() calls with wait(). But in this case sleep()

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-05 Thread via GitHub
Copilot commented on code in PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#discussion_r2128239203 ## engine/orchestration/src/main/java/com/cloud/agent/manager/DirectAgentAttache.java: ## @@ -165,7 +165,7 @@ protected synchronized void runInContext() {

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-06-05 Thread via GitHub
sureshanaparti commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2943200765 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-03-11 Thread via GitHub
DaanHoogland commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2703469551 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-03-11 Thread via GitHub
weizhouapache commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2710483620 @blueorangutan test ol8 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-03-11 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2712960353 [SF] Trillian test result (tid-12635) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 64123 seconds Marvin logs: https://githu

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-03-10 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2710489593 @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To re

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-03-10 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2710430841 [SF] Trillian test result (tid-12623) Environment: kvm-ol9 (x2), Advanced Networking with Mgmt server ol9 Total time taken: 60312 seconds Marvin logs: https://github.co

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-03-08 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2703620463 Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 12680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-03-07 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2703470656 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-03-07 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2706451466 [SF] Trillian Build Failed (tid-12615) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-03-06 Thread via GitHub
DaanHoogland commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2703691828 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-03-06 Thread via GitHub
DaanHoogland commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2703467844 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-03-06 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2705525061 [SF] Trillian test result (tid-12599) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 56751 seconds Marvin logs: https://github.co

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-03-06 Thread via GitHub
codecov[bot] commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2703485965 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10504?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-03-06 Thread via GitHub
blueorangutan commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2703696558 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-03-06 Thread via GitHub
DaanHoogland commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2703467321 thanks @sroopsai , let's test this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Refactor: Replace sleep() with wait() [cloudstack]

2025-03-05 Thread via GitHub
boring-cyborg[bot] commented on PR #10504: URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2700688187 Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contrib