Re: [PR] Fix the Cloudian Integration SSO Redirect link [cloudstack]

2024-09-10 Thread via GitHub
tpodowd commented on PR #9656: URL: https://github.com/apache/cloudstack/pull/9656#issuecomment-2341968398 Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Fix the Cloudian Integration SSO Redirect link [cloudstack]

2024-09-10 Thread via GitHub
DaanHoogland merged PR #9656: URL: https://github.com/apache/cloudstack/pull/9656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] Fix the Cloudian Integration SSO Redirect link [cloudstack]

2024-09-10 Thread via GitHub
blueorangutan commented on PR #9656: URL: https://github.com/apache/cloudstack/pull/9656#issuecomment-2340286137 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Fix the Cloudian Integration SSO Redirect link [cloudstack]

2024-09-10 Thread via GitHub
DaanHoogland commented on PR #9656: URL: https://github.com/apache/cloudstack/pull/9656#issuecomment-2340126398 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix the Cloudian Integration SSO Redirect link [cloudstack]

2024-09-10 Thread via GitHub
DaanHoogland commented on PR #9656: URL: https://github.com/apache/cloudstack/pull/9656#issuecomment-2340126096 looks good @tpodowd , letś just run the packaging once more. the regressions tests won't hit this, so if it packages fine, we can merge. -- This is an automated message from the

Re: [PR] Fix the Cloudian Integration SSO Redirect link [cloudstack]

2024-09-09 Thread via GitHub
tpodowd commented on PR #9656: URL: https://github.com/apache/cloudstack/pull/9656#issuecomment-2339706905 > > Hi @DaanHoogland - do I need to do anything regarding the code coverage report warning? > > @tpodowd , If you think this line is worth a unit test you are welcome to create

Re: [PR] Fix the Cloudian Integration SSO Redirect link [cloudstack]

2024-09-09 Thread via GitHub
DaanHoogland commented on PR #9656: URL: https://github.com/apache/cloudstack/pull/9656#issuecomment-2338023372 > Hi @DaanHoogland - do I need to do anything regarding the code coverage report warning? @tpodowd , If you think this line is worth a unit test you are welcome to create o

Re: [PR] Fix the Cloudian Integration SSO Redirect link [cloudstack]

2024-09-09 Thread via GitHub
DaanHoogland commented on PR #9656: URL: https://github.com/apache/cloudstack/pull/9656#issuecomment-2337412400 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix the Cloudian Integration SSO Redirect link [cloudstack]

2024-09-09 Thread via GitHub
DaanHoogland commented on PR #9656: URL: https://github.com/apache/cloudstack/pull/9656#issuecomment-2337411012 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix the Cloudian Integration SSO Redirect link [cloudstack]

2024-09-09 Thread via GitHub
boring-cyborg[bot] commented on PR #9656: URL: https://github.com/apache/cloudstack/pull/9656#issuecomment-2337320478 Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribut