Re: [PR] Fix secondary storage selectors feature [cloudstack]

2025-03-12 Thread via GitHub
winterhazel commented on code in PR #10546: URL: https://github.com/apache/cloudstack/pull/10546#discussion_r1991132606 ## server/src/main/java/org/apache/cloudstack/storage/heuristics/presetvariables/GenericHeuristicPresetVariable.java: ## @@ -38,8 +38,6 @@ public void setName(

Re: [PR] Fix secondary storage selectors feature [cloudstack]

2025-03-12 Thread via GitHub
DaanHoogland commented on PR #10546: URL: https://github.com/apache/cloudstack/pull/10546#issuecomment-2717218742 lgtm, @vishesh92 , can you check if there was a pressing reason the string `GenericHeuristicPresetVariable` was included in `toString()`? -- This is an automated message from

Re: [PR] Fix secondary storage selectors feature [cloudstack]

2025-03-12 Thread via GitHub
vishesh92 commented on PR #10546: URL: https://github.com/apache/cloudstack/pull/10546#issuecomment-2717231055 > lgtm, @vishesh92 , can you check if there was a pressing reason the string `GenericHeuristicPresetVariable` was included in `toString()`? It was just to improve logging.

Re: [PR] Fix secondary storage selectors feature [cloudstack]

2025-03-12 Thread via GitHub
vishesh92 commented on code in PR #10546: URL: https://github.com/apache/cloudstack/pull/10546#discussion_r1991049054 ## server/src/main/java/org/apache/cloudstack/storage/heuristics/presetvariables/GenericHeuristicPresetVariable.java: ## @@ -38,8 +38,6 @@ public void setName(St

Re: [PR] Fix secondary storage selectors feature [cloudstack]

2025-03-11 Thread via GitHub
blueorangutan commented on PR #10546: URL: https://github.com/apache/cloudstack/pull/10546#issuecomment-2715200718 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Fix secondary storage selectors feature [cloudstack]

2025-03-11 Thread via GitHub
codecov[bot] commented on PR #10546: URL: https://github.com/apache/cloudstack/pull/10546#issuecomment-2715036891 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10546?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

Re: [PR] Fix secondary storage selectors feature [cloudstack]

2025-03-11 Thread via GitHub
winterhazel commented on PR #10546: URL: https://github.com/apache/cloudstack/pull/10546#issuecomment-2715019167 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Fix secondary storage selectors feature [cloudstack]

2025-03-11 Thread via GitHub
blueorangutan commented on PR #10546: URL: https://github.com/apache/cloudstack/pull/10546#issuecomment-2715020733 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres