JoaoJandre commented on PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3139825845
> > It is not marked in the database currently, do you see a reason to do
this?
>
> @JoaoJandre in any case, if the user or operator wants to know if the
volume is a full c
sureshanaparti merged PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr..
sureshanaparti commented on PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3137198402
>
> It is not marked in the database currently, do you see a reason to do this?
>
@JoaoJandre in any case, if the user or operator wants to know if the volume
is
JoaoJandre commented on PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3137051082
> @JoaoJandre Will there be any issue in migration when one host has
create.full.clone=false,and the other has it true. Is it marked for the volume
any where in the volumes/other
sureshanaparti commented on PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3135630898
@JoaoJandre Will there be any issue in migration when one host has
create.full.clone=false,and the other has it true. Is it marked for the volume
any where in the volumes/oth
sureshanaparti commented on PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3135611497
@slavkap are you good with the PR, any concerns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
slavkap commented on PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3132837687
@DaanHoogland, I just expressed my concerns, and opening an issue is fine
with me. I'm also okay with the way the solution has been presented, but I’ll
probably be able to review it
DaanHoogland commented on PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3132481502
> @slavkap @weizhouapache I understand your point of having more flexibility
by being able to choose whether individual volumes will be full or linked
clone. However, in the use
JoaoJandre commented on PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3132153747
@slavkap @weizhouapache I understand your point of having more flexibility
by being able to choose whether individual volumes will be full or linked
clone. However, in the use cas
blueorangutan commented on PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3126141832
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
blueorangutan commented on PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3125719833
@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It
will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep
you posted as I make prog
rosi-shapeblue commented on PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3125713749
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
weizhouapache commented on PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3073269483
> For me, the code looks good, but my only concern here is that the
configuration `create.full.clone` should come from the management service as an
API parameter or a property
slavkap commented on PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3073096971
For me, the code looks good, but my only concern here is that the
configuration `create.full.clone` should come from the management service as an
API parameter or a property of a vol
DaanHoogland commented on PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3069859712
> This is the use case of THIN and full-clone. You copy the template but do
not preallocate the full disk size.
ok, so this is not a thick provisioned copy buyt just a byt
JoaoJandre commented on PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3069782796
> took me a while of looking at this to have the penny drop. Code looks good
@JoaoJandre , but what is the use case for this? I’d say one would want thin to
be thin and fat to be
Copilot commented on code in PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177#discussion_r2204657637
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##
@@ -1315,14 +1317,22 @@ public KVMPhysicalDisk
createDisk
sureshanaparti commented on PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3069116532
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
codecov[bot] commented on PR #11177:
URL: https://github.com/apache/cloudstack/pull/11177#issuecomment-3057209606
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11177?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme
19 matches
Mail list logo
