rohityadavcloud merged PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
rohityadavcloud commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-3043962347
LGTM, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
rosi-shapeblue commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-3043834184
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
blueorangutan commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-3031978475
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
blueorangutan commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-3031294224
@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
sudo87 commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-3031291387
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
blueorangutan commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2966020794
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 13744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
vishesh92 commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2965565509
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2966310983
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
blueorangutan commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2966104937
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you
posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond
github-actions[bot] commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2965508340
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache
blueorangutan commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2966157444
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10951 (QA-JID-646)
--
This is an automated message from the Apache Git Service.
To respon
blueorangutan commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2966104926
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be
bundled with@blueorangutan ui SystemVM template(s). I'll keep you posted as I
make progress.
--
T
vishesh92 commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2966102402
@blueorangutan package
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
blueorangutan commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2965568710
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
vishesh92 commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2962092295
@sudo87 Found an issue.
When the banner is not closed,
1. Open a list view (e.g. projects) or details page (e.g. Public IP Address)
2. On scrolling down, there is a gray are
blueorangutan commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2961420378
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10951 (QA-JID-643)
--
This is an automated message from the Apache Git Service.
To respon
blueorangutan commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2961386400
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you
posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond t
shwstppr commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2961385355
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
blueorangutan commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2955949796
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
blueorangutan commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2955751534
@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
sudo87 commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2955747997
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
sudo87 commented on code in PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#discussion_r2131491026
##
ui/package-lock.json:
##
Review Comment:
@harikrishna-patnala If I understand it correctly, as new dependency
(dompurify) is added in the project, that has
blueorangutan commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2944347589
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
blueorangutan commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2943873768
@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
sudo87 commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2943872365
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
harikrishna-patnala commented on code in PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#discussion_r2128542658
##
ui/package-lock.json:
##
Review Comment:
@sudo87 I don't think we need to push the package-lock and packages json
files. You can quickly try r
blueorangutan commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2943008319
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10951 (QA-JID-637)
--
This is an automated message from the Apache Git Service.
To respon
blueorangutan commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2942970180
@sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you
posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to
sudo87 commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2942968826
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
sudo87 commented on code in PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#discussion_r2128019514
##
ui/package-lock.json:
##
Review Comment:
@bernardodemarco package-lock.json is updated with required depedency.
It used to have huge diff as I have node
bernardodemarco commented on code in PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#discussion_r2126476722
##
ui/package-lock.json:
##
Review Comment:
@sudo87, could you remove the changes performed in the
`ui/package-lock.json` file?
--
This is an aut
codecov[bot] commented on PR #10951:
URL: https://github.com/apache/cloudstack/pull/10951#issuecomment-2939336256
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10951?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme
33 matches
Mail list logo
