JoaoJandre merged PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@clou
JoaoJandre commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-2006999352
> This is an edge case not easy to reproduce but found in a prod customer
env @JoaoJandre. To reproduce you can delete a volume from the db manually
which has a snapshot policy.
rohityadavcloud commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-2006258743
This is an edge case not easy to reproduce but found in a prod customer env
@JoaoJandre. To reproduce you can delete a volume from the db manually which
has a snapshot policy.
JoaoJandre commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-2003796954
I tried to test this manually but was not able to reproduce the issue,
@rohityadavcloud could you share the steps to reproduce this?
--
This is an automated message from the
rohityadavcloud commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-2003788044
@JoaoJandre since you're the RM who has called off a freeze, could you merge
this?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
blueorangutan commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-1996728039
[SF] Trillian test result (tid-9467)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39891 seconds
Marvin logs:
https://github.com
blueorangutan commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-1995577584
@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To
weizhouapache commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-1995571059
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
blueorangutan commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-1995315054
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-1995063586
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It
will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep
you posted as I make progr
rohityadavcloud commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-1995061487
@weizhouapache I like your idea, could you propose that as a separate PR.
For now I've added changes to remove the schedule when volume is missing.
Requesting re-review c
rohityadavcloud commented on code in PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#discussion_r1523647289
##
server/src/main/java/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java:
##
@@ -378,6 +378,12 @@ public Date scheduleNextSnapshotJob(final SnapshotPoli
blueorangutan commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-1976109496
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
rajujith commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-1976024622
> what if the volume is removed manually after snapshot policy is created ?
>
> it may be better to add constraint to the table `snapshot_policy`, to
prevent the volume to be re
blueorangutan commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-1975996941
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progres
weizhouapache commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-1975993586
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
weizhouapache commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-1975991149
> > what if the volume is removed manually after snapshot policy is created ?
> > it may be better to add constraint to the table `snapshot_policy`, to
prevent the volume to be
DaanHoogland commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-1975956453
> what if the volume is removed manually after snapshot policy is created ?
>
> it may be better to add constraint to the table `snapshot_policy`, to
prevent the volume to b
rohityadavcloud commented on code in PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#discussion_r1509280783
##
server/src/main/java/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java:
##
@@ -378,6 +378,12 @@ public Date scheduleNextSnapshotJob(final SnapshotPoli
blueorangutan commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-1973403110
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
sureshanaparti commented on code in PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#discussion_r1509169015
##
server/src/main/java/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java:
##
@@ -378,6 +378,12 @@ public Date scheduleNextSnapshotJob(final SnapshotPolic
codecov[bot] commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-1973375876
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8735?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
weizhouapache commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-1973328104
what if the volume is removed manually after snapshot policy is created ?
it may be better to add constraint to the table `snapshot_policy`, to
prevent the volume to be rem
DaanHoogland commented on code in PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#discussion_r150903
##
server/src/main/java/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java:
##
@@ -378,6 +378,12 @@ public Date scheduleNextSnapshotJob(final SnapshotPolicyV
blueorangutan commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-1973310401
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It
will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep
you posted as I make progr
rohityadavcloud opened a new pull request, #8735:
URL: https://github.com/apache/cloudstack/pull/8735
When management server starts, it starts the snapshot scheduler. In case
there is a volume snapshot policy which exists for a volume which does not
exist, it can cause SQL constraint issue
rohityadavcloud commented on PR #8735:
URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-1973307262
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
27 matches
Mail list logo
