DaanHoogland merged PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cl
DaanHoogland commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2543319614
tested with a user-, user+, domadmin- and domadmin+ role to see wich was
possible.
I gave the domadmin roles updateRole and updateRolePermissions to try and
edit roles betond t
blueorangutan commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2518845134
[SF] Trillian test result (tid-11844)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 52403 seconds
Marvin logs:
https://github.com/
blueorangutan commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2516671502
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been
kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond t
DaanHoogland commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2516669225
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
blueorangutan commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2516601466
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
DaanHoogland commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2516421394
thanks @shwstppr , on the list ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
blueorangutan commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2516409126
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
shwstppr commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2516408138
@DaanHoogland I think this is okay from my side but will need some testing.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to t
github-actions[bot] commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2516395292
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
DaanHoogland commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2464987315
@shwstppr , do we still have functional doubts on the current state of the
code? (or can we postpone further discussion to a next issue/PR)
--
This is an automated message from
blueorangutan commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2359841495
[SF] Trillian test result (tid-11512)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 46532 seconds
Marvin logs:
https://github.com/
blueorangutan commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2358362113
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been
kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond t
DaanHoogland commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2358360067
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
blueorangutan commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2358248757
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
blueorangutan commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2358128302
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress
DaanHoogland commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2358126337
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2304617606
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
blueorangutan commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2304496737
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
shwstppr commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2304492647
> > I would expect a Domain Admin to promote a user up to their own level.
>
> I feel this shouldn't be allowed. It should be done by account with higher
privileges, ROOT admin
github-actions[bot] commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2271776166
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
blueorangutan commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2242433128
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2242214945
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
shwstppr commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2242211781
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
DaanHoogland commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2164985302
Thanks @shwstppr
> * Domain-admins (if allowed based on API permission) can promote or demote
an account to roles lower than domain-admin level. _They won't be able to make
shwstppr commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2165011801
>
> I would expect a Domain Admin to promote a user up to their own level.
>
I feel this shouldn't be allowed. It should be done by account with higher
privileges, ROOT
shwstppr commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2164885064
@DaanHoogland @rohityadavcloud
Thanks for the review but I'm not sure if we agree on the behaviour which is
why this is still in draft. I will try to summarise impact of this chang
blueorangutan commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2153265443
[SF] Trillian test result (tid-10374)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42525 seconds
Marvin logs:
https://github.co
blueorangutan commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2151567175
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To r
DaanHoogland commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2151566280
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
shwstppr commented on code in PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#discussion_r1627626654
##
server/src/main/java/com/cloud/user/AccountManagerImpl.java:
##
@@ -1287,16 +1287,33 @@ public Pair
doInTransaction(TransactionStatus status) {
return
DaanHoogland commented on code in PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#discussion_r1627495823
##
server/src/main/java/com/cloud/user/AccountManagerImpl.java:
##
@@ -1287,16 +1287,33 @@ public Pair
doInTransaction(TransactionStatus status) {
ret
blueorangutan commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2149441964
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2149285027
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
shwstppr commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2149282555
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
blueorangutan commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2149264795
Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2149214133
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
codecov[bot] commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2149213514
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9173?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
shwstppr commented on PR #9173:
URL: https://github.com/apache/cloudstack/pull/9173#issuecomment-2149212062
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
shwstppr opened a new pull request, #9173:
URL: https://github.com/apache/cloudstack/pull/9173
### Description
Fixes #9015
Simplifies role change checks with the following conditions:
- Caller should not be of Unknown role type
- New role's type should not be Unknown
40 matches
Mail list logo
