Re: [PR] server: fix typo removeaccessvpn in VirtualRouterElement [cloudstack]

2024-12-13 Thread via GitHub
DaanHoogland merged PR #10086: URL: https://github.com/apache/cloudstack/pull/10086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [PR] server: fix typo removeaccessvpn in VirtualRouterElement [cloudstack]

2024-12-12 Thread via GitHub
weizhouapache commented on PR #10086: URL: https://github.com/apache/cloudstack/pull/10086#issuecomment-2540801125 > Can we do any other testing on this @weizhouapache , it seems to me this would be good enough. @DaanHoogland I think no more testing is needed. it is just a typo

Re: [PR] server: fix typo removeaccessvpn in VirtualRouterElement [cloudstack]

2024-12-12 Thread via GitHub
DaanHoogland commented on PR #10086: URL: https://github.com/apache/cloudstack/pull/10086#issuecomment-2540584155 Can we do any other testing on this @weizhouapache , it seems to me this would be good enough. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] server: fix typo removeaccessvpn in VirtualRouterElement [cloudstack]

2024-12-12 Thread via GitHub
blueorangutan commented on PR #10086: URL: https://github.com/apache/cloudstack/pull/10086#issuecomment-2540452035 [SF] Trillian test result (tid-11894) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 45487 seconds Marvin logs: https://github.co

Re: [PR] server: fix typo removeaccessvpn in VirtualRouterElement [cloudstack]

2024-12-12 Thread via GitHub
blueorangutan commented on PR #10086: URL: https://github.com/apache/cloudstack/pull/10086#issuecomment-2539050735 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond

Re: [PR] server: fix typo removeaccessvpn in VirtualRouterElement [cloudstack]

2024-12-12 Thread via GitHub
DaanHoogland commented on PR #10086: URL: https://github.com/apache/cloudstack/pull/10086#issuecomment-2539046084 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] server: fix typo removeaccessvpn in VirtualRouterElement [cloudstack]

2024-12-12 Thread via GitHub
blueorangutan commented on PR #10086: URL: https://github.com/apache/cloudstack/pull/10086#issuecomment-2538823342 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] server: fix typo removeaccessvpn in VirtualRouterElement [cloudstack]

2024-12-11 Thread via GitHub
codecov[bot] commented on PR #10086: URL: https://github.com/apache/cloudstack/pull/10086#issuecomment-2535893679 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10086?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

Re: [PR] server: fix typo removeaccessvpn in VirtualRouterElement [cloudstack]

2024-12-11 Thread via GitHub
DaanHoogland commented on PR #10086: URL: https://github.com/apache/cloudstack/pull/10086#issuecomment-2535890838 `VirtualRouterElement` can actually do with some extra clean up in addition to this. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[PR] server: fix typo removeaccessvpn in VirtualRouterElement [cloudstack]

2024-12-11 Thread via GitHub
weizhouapache opened a new pull request, #10086: URL: https://github.com/apache/cloudstack/pull/10086 ### Description This PR fixes the typo `removeaccessvpn` which should be `remoteaccessvpn` ### Types of changes