blueorangutan commented on PR #9202:
URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2175521105
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
rohityadavcloud commented on PR #9202:
URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2175403710
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
blueorangutan commented on PR #9202:
URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2175404676
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It
will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep
you posted as I make progr
github-actions[bot] commented on PR #9202:
URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2167432488
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
shwstppr commented on PR #9202:
URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2165069877
yes, currently it won't benefit. Will try to explore a generic interface
like BaseVmManager in the coming weeks
--
This is an automated message from the Apache Git Service.
To respo
DaanHoogland commented on PR #9202:
URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2164993834
> oh. I thought you meant using a single method. That can be changed. I
based the on the existing methods in the service, eg:
https://github.com/apache/cloudstack/pull/9202/files#
blueorangutan commented on PR #9202:
URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2165000218
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
shwstppr commented on PR #9202:
URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2164951242
oh. I thought you meant using a single method. That can be changed. I based
the on the existing methods in the service, eg:
https://github.com/apache/cloudstack/pull/9202/files#diff-9
DaanHoogland commented on PR #9202:
URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2164942867
> @DaanHoogland separate methods are called allow publishing of events of
different types. Initially, I did the same. Other way to allow publishing of
correct events could be manu
blueorangutan commented on PR #9202:
URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2164812940
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
shwstppr commented on PR #9202:
URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2164809768
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
shwstppr commented on PR #9202:
URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2164808690
@DaanHoogland separate methods are called allow publishing of events of
different types. Initially, I did the same.
Other way to allow publishing of correct events could be manually
DaanHoogland commented on code in PR #9202:
URL: https://github.com/apache/cloudstack/pull/9202#discussion_r1637682201
##
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxy.java:
##
@@ -1,3 +1,4 @@
+
Review Comment:
```suggestion
```
--
Th
codecov[bot] commented on PR #9202:
URL: https://github.com/apache/cloudstack/pull/9202#issuecomment-2158328664
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9202?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
shwstppr opened a new pull request, #9202:
URL: https://github.com/apache/cloudstack/pull/9202
### Description
Fixes #8021
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking cha
15 matches
Mail list logo
