Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

DaanHoogland merged PR #9057: URL: https://github.com/apache/cloudstack/pull/9057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

vishesh92 commented on code in PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#discussion_r1629063066 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterHelperImpl.java: ## @@ -16,26 +16,48 @@ // under the Licens

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

shwstppr commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2149223147 Added test API calls in the PR description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

blueorangutan commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2134019972 [SF] Trillian test result (tid-10283) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42160 seconds Marvin logs: https://github.co

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

blueorangutan commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2132922635 @shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respo

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

shwstppr commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2132920781 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

blueorangutan commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2129523685 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9695 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

blueorangutan commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2129321101 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

shwstppr commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2129318409 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

blueorangutan commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2124474259 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9665 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

blueorangutan commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2124227857 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

shwstppr commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2124224984 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

blueorangutan commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2124046159 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9656 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

blueorangutan commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2123935046 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

shwstppr commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2123933525 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

weizhouapache commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2102920805 > @weizhouapache on the special case discussed earlier, @Pearl1594 made me aware that we already have an option with scaleKubernetesCluster API to delete a specific node using `n

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

shwstppr commented on code in PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#discussion_r1595345989 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterHelperImpl.java: ## @@ -16,26 +16,48 @@ // under the License

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

shwstppr commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2102512565 @weizhouapache on the special case discussed earlier, @Pearl1594 made me aware that we already have an option with scaleKubernetesCluster API to delete a specific node using `nodeids`

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

vishesh92 commented on code in PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#discussion_r1595185688 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterHelperImpl.java: ## @@ -16,26 +16,48 @@ // under the Licens

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

sureshanaparti commented on code in PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#discussion_r1593917707 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterHelperImpl.java: ## @@ -16,26 +16,48 @@ // under the L

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

weizhouapache commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2100365009 > > @shwstppr I am not sure if we should disallow the operation. > > would it be a valid use case for users to > > ``` > > * drain the node in CKS > > > > * remove

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

shwstppr commented on code in PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#discussion_r1593852342 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterHelperImpl.java: ## @@ -16,26 +16,48 @@ // under the License

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

shwstppr commented on code in PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#discussion_r1593851178 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterHelperImpl.java: ## @@ -16,26 +16,48 @@ // under the License

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

shwstppr commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2100327437 > @shwstppr I am not sure if we should disallow the operation. > > would it be a valid use case for users to > > * drain the node in CKS > > * remove the no

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

sureshanaparti commented on code in PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#discussion_r1593840190 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterHelperImpl.java: ## @@ -16,26 +16,48 @@ // under the L

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

sureshanaparti commented on code in PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#discussion_r1593839206 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterHelperImpl.java: ## @@ -16,26 +16,48 @@ // under the L

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

weizhouapache commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2100304314 @shwstppr I am not sure if we should disallow the operation. would it be a valid use case for users to - drain the node in CKS - remove the node vm from cloudstack

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

codecov-commenter commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2100148082 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9057?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+com

[PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

shwstppr opened a new pull request, #9057: URL: https://github.com/apache/cloudstack/pull/9057 ### Description Fixes #8902 ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking cha