Re: [PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-08-22 Thread via GitHub
blueorangutan commented on PR #9401: URL: https://github.com/apache/cloudstack/pull/9401#issuecomment-2305011326 Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 10758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-08-22 Thread via GitHub
blueorangutan commented on PR #9401: URL: https://github.com/apache/cloudstack/pull/9401#issuecomment-2304735602 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-08-22 Thread via GitHub
DaanHoogland commented on PR #9401: URL: https://github.com/apache/cloudstack/pull/9401#issuecomment-2304731542 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-08-22 Thread via GitHub
DaanHoogland commented on PR #9401: URL: https://github.com/apache/cloudstack/pull/9401#issuecomment-2304730152 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-08-14 Thread via GitHub
DaanHoogland commented on PR #9401: URL: https://github.com/apache/cloudstack/pull/9401#issuecomment-2288851468 @KlausDornsbach , can you resolve the conflicts, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-08-14 Thread via GitHub
github-actions[bot] commented on PR #9401: URL: https://github.com/apache/cloudstack/pull/9401#issuecomment-2288802803 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-07-19 Thread via GitHub
DaanHoogland commented on PR #9401: URL: https://github.com/apache/cloudstack/pull/9401#issuecomment-2239057911 @rohityadavcloud , both upgradespassed in the an automated upgrade test with test VMs etc. Is this good enough you think? -- This is an automated message from the Apache Git Ser

Re: [PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-07-19 Thread via GitHub
rohityadavcloud commented on PR #9401: URL: https://github.com/apache/cloudstack/pull/9401#issuecomment-2238162703 LGTM, but I'm not sure if it would break anything that may require the views to be created during db upgrade paths are executed and before the views are created (or re-created)

Re: [PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-07-19 Thread via GitHub
DaanHoogland commented on PR #9401: URL: https://github.com/apache/cloudstack/pull/9401#issuecomment-2238624521 > LGTM, but I'm not sure if it would break anything that may require the views to be created during db upgrade paths are executed and before the views are created (or re-created).

Re: [PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-07-18 Thread via GitHub
blueorangutan commented on PR #9401: URL: https://github.com/apache/cloudstack/pull/9401#issuecomment-2237774187 [SF] Trillian test result (tid-10905) Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8 Total time taken: 49093 seconds Marvin logs: https://github.com

Re: [PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-07-17 Thread via GitHub
KlausDornsbach commented on PR #9401: URL: https://github.com/apache/cloudstack/pull/9401#issuecomment-2233273179 Thanks for the heads up, did a double check and things are looking fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-07-16 Thread via GitHub
blueorangutan commented on PR #9401: URL: https://github.com/apache/cloudstack/pull/9401#issuecomment-2232551890 [SF] Trillian Build Failed (tid-10883) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-07-16 Thread via GitHub
blueorangutan commented on PR #9401: URL: https://github.com/apache/cloudstack/pull/9401#issuecomment-2232527117 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-07-16 Thread via GitHub
DaanHoogland commented on PR #9401: URL: https://github.com/apache/cloudstack/pull/9401#issuecomment-2232525955 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-07-16 Thread via GitHub
blueorangutan commented on PR #9401: URL: https://github.com/apache/cloudstack/pull/9401#issuecomment-2231727468 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10381 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-07-16 Thread via GitHub
codecov[bot] commented on PR #9401: URL: https://github.com/apache/cloudstack/pull/9401#issuecomment-2231612684 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9401?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-07-16 Thread via GitHub
blueorangutan commented on PR #9401: URL: https://github.com/apache/cloudstack/pull/9401#issuecomment-2231591102 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-07-16 Thread via GitHub
DaanHoogland commented on PR #9401: URL: https://github.com/apache/cloudstack/pull/9401#issuecomment-2231589759 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] refactoring views out of upgrade db schema scripts [cloudstack]

2024-07-16 Thread via GitHub
KlausDornsbach opened a new pull request, #9401: URL: https://github.com/apache/cloudstack/pull/9401 ### Description Based on the comment https://github.com/apache/cloudstack/pull/9385#issuecomment-2227061721 from @DaanHogland, and considering that all the DB view definitions are cur