Re: [PR] refactor schema-41910to42000.sql [cloudstack]

2024-09-16 Thread via GitHub
JoaoJandre commented on PR #9680: URL: https://github.com/apache/cloudstack/pull/9680#issuecomment-2352819932 > @JoaoJandre , for people using mariadb 10 this is actually a blocker. I don't know if mariadb10 is well supported otherwise, but I think we should include this. Yes we are

Re: [PR] refactor schema-41910to42000.sql [cloudstack]

2024-09-16 Thread via GitHub
DaanHoogland commented on PR #9680: URL: https://github.com/apache/cloudstack/pull/9680#issuecomment-2352750285 @JoaoJandre , for people using mariadb 10 this is actually a blocker. I don't know if mariadb10 is well supported otherwise, but I think we should include this. -- This is an a

Re: [PR] refactor schema-41910to42000.sql [cloudstack]

2024-09-16 Thread via GitHub
weizhouapache commented on PR #9680: URL: https://github.com/apache/cloudstack/pull/9680#issuecomment-2352394069 @LayonRibeiro can you update the title with a short summary of the issue ? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] refactor schema-41910to42000.sql [cloudstack]

2024-09-16 Thread via GitHub
weizhouapache commented on PR #9680: URL: https://github.com/apache/cloudstack/pull/9680#issuecomment-2352393044 code lgtm @JoaoJandre @DaanHoogland If the issue exists with mariadb 10 and is fixed by this PR, we should merge this. -- This is an automated message from the A

Re: [PR] refactor schema-41910to42000.sql [cloudstack]

2024-09-16 Thread via GitHub
blueorangutan commented on PR #9680: URL: https://github.com/apache/cloudstack/pull/9680#issuecomment-2352252130 @DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] refactor schema-41910to42000.sql [cloudstack]

2024-09-16 Thread via GitHub
DaanHoogland commented on PR #9680: URL: https://github.com/apache/cloudstack/pull/9680#issuecomment-2352250718 @blueorangutan LLtest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] refactor schema-41910to42000.sql [cloudstack]

2024-09-13 Thread via GitHub
blueorangutan commented on PR #9680: URL: https://github.com/apache/cloudstack/pull/9680#issuecomment-2350709970 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] refactor schema-41910to42000.sql [cloudstack]

2024-09-13 Thread via GitHub
codecov[bot] commented on PR #9680: URL: https://github.com/apache/cloudstack/pull/9680#issuecomment-2350598491 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9680?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] refactor schema-41910to42000.sql [cloudstack]

2024-09-13 Thread via GitHub
blueorangutan commented on PR #9680: URL: https://github.com/apache/cloudstack/pull/9680#issuecomment-2350574945 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

Re: [PR] refactor schema-41910to42000.sql [cloudstack]

2024-09-13 Thread via GitHub
weizhouapache commented on PR #9680: URL: https://github.com/apache/cloudstack/pull/9680#issuecomment-2350570965 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] refactor schema-41910to42000.sql [cloudstack]

2024-09-13 Thread via GitHub
LayonRibeiro opened a new pull request, #9680: URL: https://github.com/apache/cloudstack/pull/9680 ### Description This PR changes two column renames in `schema-41910to42000.sql`. Using MariaDB version `10.3.38-MariaDB`, some lines are not applying the expected changes to the column