Re: [PR] pre-commit: check more file types for trailing whitespace [cloudstack]

2024-07-10 Thread via GitHub
DaanHoogland merged PR #9352: URL: https://github.com/apache/cloudstack/pull/9352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] pre-commit: check more file types for trailing whitespace [cloudstack]

2024-07-09 Thread via GitHub
DaanHoogland commented on code in PR #9352: URL: https://github.com/apache/cloudstack/pull/9352#discussion_r1669909727 ## .pre-commit-config.yaml: ## @@ -59,8 +59,9 @@ repos: - id: mixed-line-ending exclude: \.(cs|xml)$ - id: trailing-whitespace -f

Re: [PR] pre-commit: check more file types for trailing whitespace [cloudstack]

2024-07-08 Thread via GitHub
jbampton commented on code in PR #9352: URL: https://github.com/apache/cloudstack/pull/9352#discussion_r1669622409 ## .pre-commit-config.yaml: ## @@ -59,8 +59,9 @@ repos: - id: mixed-line-ending exclude: \.(cs|xml)$ - id: trailing-whitespace -files

Re: [PR] pre-commit: check more file types for trailing whitespace [cloudstack]

2024-07-08 Thread via GitHub
blueorangutan commented on PR #9352: URL: https://github.com/apache/cloudstack/pull/9352#issuecomment-2215205201 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10297 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] pre-commit: check more file types for trailing whitespace [cloudstack]

2024-07-08 Thread via GitHub
DaanHoogland commented on code in PR #9352: URL: https://github.com/apache/cloudstack/pull/9352#discussion_r1669171260 ## .pre-commit-config.yaml: ## @@ -59,8 +59,9 @@ repos: - id: mixed-line-ending exclude: \.(cs|xml)$ - id: trailing-whitespace -f

Re: [PR] pre-commit: check more file types for trailing whitespace [cloudstack]

2024-07-08 Thread via GitHub
blueorangutan commented on PR #9352: URL: https://github.com/apache/cloudstack/pull/9352#issuecomment-2214971363 @jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] pre-commit: check more file types for trailing whitespace [cloudstack]

2024-07-08 Thread via GitHub
jbampton commented on PR #9352: URL: https://github.com/apache/cloudstack/pull/9352#issuecomment-2214965878 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] pre-commit: check more file types for trailing whitespace [cloudstack]

2024-07-08 Thread via GitHub
codecov[bot] commented on PR #9352: URL: https://github.com/apache/cloudstack/pull/9352#issuecomment-2214120699 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9352?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] pre-commit: check more file types for trailing whitespace [cloudstack]

2024-07-08 Thread via GitHub
jbampton opened a new pull request, #9352: URL: https://github.com/apache/cloudstack/pull/9352 ### Description This PR checks more file types for unneeded trailing whitespace. Trailing whitespace is just extra data that we don't need. This hook when run locally will autom