Re: [PR] pre-commit: add `XML` files to the `trailing-whitespace` check [cloudstack]

DaanHoogland merged PR #9131: URL: https://github.com/apache/cloudstack/pull/9131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] pre-commit: add `XML` files to the `trailing-whitespace` check [cloudstack]

blueorangutan commented on PR #9131: URL: https://github.com/apache/cloudstack/pull/9131#issuecomment-809508 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10323 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] pre-commit: add `XML` files to the `trailing-whitespace` check [cloudstack]

blueorangutan commented on PR #9131: URL: https://github.com/apache/cloudstack/pull/9131#issuecomment-626632 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] pre-commit: add `XML` files to the `trailing-whitespace` check [cloudstack]

DaanHoogland commented on PR #9131: URL: https://github.com/apache/cloudstack/pull/9131#issuecomment-625889 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] pre-commit: add `XML` files to the `trailing-whitespace` check [cloudstack]

github-actions[bot] commented on PR #9131: URL: https://github.com/apache/cloudstack/pull/9131#issuecomment-2219997529 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] pre-commit: add `XML` files to the `trailing-whitespace` check [cloudstack]

jbampton commented on PR #9131: URL: https://github.com/apache/cloudstack/pull/9131#issuecomment-2213993106 Hey @DaanHoogland I want to focus this PR just on one check or test for trailing whitespace in the XML files. In future we can do more clean ups since this PR already has over 3

Re: [PR] pre-commit: add `XML` files to the `trailing-whitespace` check [cloudstack]

DaanHoogland commented on code in PR #9131: URL: https://github.com/apache/cloudstack/pull/9131#discussion_r1668096082 ## core/src/main/resources/META-INF/cloudstack/storage/spring-lifecycle-storage-context-inheritable.xml: ## @@ -76,7 +76,7 @@ - - + +

Re: [PR] pre-commit: add `XML` files to the `trailing-whitespace` check [cloudstack]

blueorangutan commented on PR #9131: URL: https://github.com/apache/cloudstack/pull/9131#issuecomment-2212925451 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10280 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] pre-commit: add `XML` files to the `trailing-whitespace` check [cloudstack]

blueorangutan commented on PR #9131: URL: https://github.com/apache/cloudstack/pull/9131#issuecomment-2212861489 @jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] pre-commit: add `XML` files to the `trailing-whitespace` check [cloudstack]

jbampton commented on PR #9131: URL: https://github.com/apache/cloudstack/pull/9131#issuecomment-2212859789 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] pre-commit: add `XML` files to the `trailing-whitespace` check [cloudstack]

codecov[bot] commented on PR #9131: URL: https://github.com/apache/cloudstack/pull/9131#issuecomment-2134828707 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9131?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] pre-commit: add `XML` files to the `trailing-whitespace` check [cloudstack]

jbampton opened a new pull request, #9131: URL: https://github.com/apache/cloudstack/pull/9131 ### Description This PR adds checking for XML files for trailing whitespace. Trailing whitespace is mostly extra space or data we don't need.