Re: [PR] move nic removal from shutdown to expunge [cloudstack]

2023-12-18 Thread via GitHub
weizhouapache commented on PR #8371: URL: https://github.com/apache/cloudstack/pull/8371#issuecomment-1861831009 This code snippet seems not related to private ip release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] move nic removal from shutdown to expunge [cloudstack]

2023-12-18 Thread via GitHub
blueorangutan commented on PR #8371: URL: https://github.com/apache/cloudstack/pull/8371#issuecomment-1861799701 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8081 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] move nic removal from shutdown to expunge [cloudstack]

2023-12-18 Thread via GitHub
blueorangutan commented on PR #8371: URL: https://github.com/apache/cloudstack/pull/8371#issuecomment-1861695779 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] move nic removal from shutdown to expunge [cloudstack]

2023-12-18 Thread via GitHub
DaanHoogland commented on PR #8371: URL: https://github.com/apache/cloudstack/pull/8371#issuecomment-1861692062 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] move nic removal from shutdown to expunge [cloudstack]

2023-12-18 Thread via GitHub
codecov[bot] commented on PR #8371: URL: https://github.com/apache/cloudstack/pull/8371#issuecomment-1861138633 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8371?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

[PR] move nic removal from shutdown to expunge [cloudstack]

2023-12-18 Thread via GitHub
DaanHoogland opened a new pull request, #8371: URL: https://github.com/apache/cloudstack/pull/8371 ### Description This PR... does an attempt at tries Fixes: #8284 ### Types of changes - [ ] Breaking change (fix or fea