abh1sar closed pull request #9096: listNetworks optimization
URL: https://github.com/apache/cloudstack/pull/9096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
shwstppr commented on PR #9096:
URL: https://github.com/apache/cloudstack/pull/9096#issuecomment-2151989532
@rohityadavcloud @abh1sar cc @weizhouapache I created a draft here
https://github.com/apache/cloudstack/pull/9184 to refactor the code to retrieve
networks from DB only once. I'm yet
abh1sar commented on PR #9096:
URL: https://github.com/apache/cloudstack/pull/9096#issuecomment-2148217554
> any update/progress on this @shwstppr ?
@rohityadavcloud,
Abhishek suggested to see if there is any alternative way to query the
networks only once using some kind of Join
rohityadavcloud commented on PR #9096:
URL: https://github.com/apache/cloudstack/pull/9096#issuecomment-2143911974
any update/progress on this @shwstppr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
shwstppr commented on PR #9096:
URL: https://github.com/apache/cloudstack/pull/9096#issuecomment-2128884280
Discussed with @abh1sar. It will be worth investigating if instead of
querying networks multiple times for different filters.
Worst case, we can use startIndex=0, pageSize=pageNumbe
rohityadavcloud commented on code in PR #9096:
URL: https://github.com/apache/cloudstack/pull/9096#discussion_r1610360509
##
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##
@@ -2267,7 +2267,7 @@ public Pair, Integer>
searchForNetworks(ListNetworksCmd
rohityadavcloud commented on code in PR #9096:
URL: https://github.com/apache/cloudstack/pull/9096#discussion_r1610359422
##
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##
@@ -2322,41 +2322,52 @@ public Pair, Integer>
searchForNetworks(ListNetworksCmd
blueorangutan commented on PR #9096:
URL: https://github.com/apache/cloudstack/pull/9096#issuecomment-2124712657
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #9096:
URL: https://github.com/apache/cloudstack/pull/9096#issuecomment-2124579954
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
shwstppr commented on PR #9096:
URL: https://github.com/apache/cloudstack/pull/9096#issuecomment-2124577944
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
abh1sar commented on code in PR #9096:
URL: https://github.com/apache/cloudstack/pull/9096#discussion_r1609327509
##
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##
@@ -2322,41 +2322,52 @@ public Pair, Integer>
searchForNetworks(ListNetworksCmd
s
abh1sar commented on code in PR #9096:
URL: https://github.com/apache/cloudstack/pull/9096#discussion_r1609315083
##
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##
@@ -2267,7 +2267,7 @@ public Pair, Integer>
searchForNetworks(ListNetworksCmd
isR
weizhouapache commented on code in PR #9096:
URL: https://github.com/apache/cloudstack/pull/9096#discussion_r1608314443
##
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##
@@ -2267,7 +2267,7 @@ public Pair, Integer>
searchForNetworks(ListNetworksCmd
weizhouapache commented on code in PR #9096:
URL: https://github.com/apache/cloudstack/pull/9096#discussion_r1608314443
##
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##
@@ -2267,7 +2267,7 @@ public Pair, Integer>
searchForNetworks(ListNetworksCmd
codecov[bot] commented on PR #9096:
URL: https://github.com/apache/cloudstack/pull/9096#issuecomment-2122541865
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9096?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
abh1sar opened a new pull request, #9096:
URL: https://github.com/apache/cloudstack/pull/9096
### Description
This PR fixes the performance issue where listNetworks api goes through all
the rows of the networks table and takes longer irrespective of the pagination
used.
[Draft
16 matches
Mail list logo
