Re: [PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-04 Thread via GitHub
blueorangutan commented on PR #9327: URL: https://github.com/apache/cloudstack/pull/9327#issuecomment-2209574760 [SF] Trillian test result (tid-10731) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47225 seconds Marvin logs: https://github.co

Re: [PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-04 Thread via GitHub
sureshanaparti merged PR #9327: URL: https://github.com/apache/cloudstack/pull/9327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-04 Thread via GitHub
blueorangutan commented on PR #9327: URL: https://github.com/apache/cloudstack/pull/9327#issuecomment-2208505779 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9327 (QA-JID-395) -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-04 Thread via GitHub
blueorangutan commented on PR #9327: URL: https://github.com/apache/cloudstack/pull/9327#issuecomment-2208468131 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-04 Thread via GitHub
DaanHoogland commented on PR #9327: URL: https://github.com/apache/cloudstack/pull/9327#issuecomment-2208465567 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-04 Thread via GitHub
DaanHoogland commented on PR #9327: URL: https://github.com/apache/cloudstack/pull/9327#issuecomment-2208465338 come to think smoke tests don't make sense for this @sureshanaparti -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-04 Thread via GitHub
rp- commented on code in PR #9327: URL: https://github.com/apache/cloudstack/pull/9327#discussion_r1665358452 ## ui/src/views/infra/AddPrimaryStorage.vue: ## @@ -879,7 +879,7 @@ export default { url = values.flashArrayURL } -if (values.provider ===

Re: [PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-04 Thread via GitHub
sureshanaparti commented on code in PR #9327: URL: https://github.com/apache/cloudstack/pull/9327#discussion_r1665288641 ## ui/src/views/infra/AddPrimaryStorage.vue: ## @@ -879,7 +879,7 @@ export default { url = values.flashArrayURL } -if (values.pr

Re: [PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-04 Thread via GitHub
blueorangutan commented on PR #9327: URL: https://github.com/apache/cloudstack/pull/9327#issuecomment-2208334150 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-04 Thread via GitHub
DaanHoogland commented on PR #9327: URL: https://github.com/apache/cloudstack/pull/9327#issuecomment-2208332048 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-03 Thread via GitHub
blueorangutan commented on PR #9327: URL: https://github.com/apache/cloudstack/pull/9327#issuecomment-2206321258 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10243 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-03 Thread via GitHub
blueorangutan commented on PR #9327: URL: https://github.com/apache/cloudstack/pull/9327#issuecomment-2206092689 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-03 Thread via GitHub
DaanHoogland commented on PR #9327: URL: https://github.com/apache/cloudstack/pull/9327#issuecomment-2206089293 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-03 Thread via GitHub
rp- commented on code in PR #9327: URL: https://github.com/apache/cloudstack/pull/9327#discussion_r1664146578 ## ui/src/views/infra/AddPrimaryStorage.vue: ## @@ -879,7 +879,7 @@ export default { url = values.flashArrayURL } -if (values.provider ===

Re: [PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-03 Thread via GitHub
DaanHoogland commented on code in PR #9327: URL: https://github.com/apache/cloudstack/pull/9327#discussion_r1663879666 ## ui/src/views/infra/AddPrimaryStorage.vue: ## @@ -879,7 +879,7 @@ export default { url = values.flashArrayURL } -if (values.prov

Re: [PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-03 Thread via GitHub
rp- commented on code in PR #9327: URL: https://github.com/apache/cloudstack/pull/9327#discussion_r1663654885 ## ui/src/views/infra/AddPrimaryStorage.vue: ## @@ -879,7 +879,7 @@ export default { url = values.flashArrayURL } -if (values.provider ===

Re: [PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-02 Thread via GitHub
DaanHoogland commented on code in PR #9327: URL: https://github.com/apache/cloudstack/pull/9327#discussion_r1663548275 ## ui/src/views/infra/AddPrimaryStorage.vue: ## @@ -879,7 +879,7 @@ export default { url = values.flashArrayURL } -if (values.prov

[PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-02 Thread via GitHub
rp- opened a new pull request, #9327: URL: https://github.com/apache/cloudstack/pull/9327 ### Description url param wasn't set if protocol Linstor is selected. This was introduced with this PR https://github.com/apache/cloudstack/pull/9138 ### Types of ch

Re: [PR] linstor-ui: Fix add primary storage if Linstor protocol selected [cloudstack]

2024-07-02 Thread via GitHub
codecov[bot] commented on PR #9327: URL: https://github.com/apache/cloudstack/pull/9327#issuecomment-2203179049 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9327?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments