Re: [PR] linstor: make getDevicePath more robust [cloudstack]

2024-06-06 Thread via GitHub
rp- commented on PR #9143: URL: https://github.com/apache/cloudstack/pull/9143#issuecomment-2152097967 > @rp- , I had some problems merging this forward. Can you review the merge commit [c779b1c](https://github.com/apache/cloudstack/commit/c779b1c616471b8fea833c4b090a7f3bc2dc6ab7) , please

Re: [PR] linstor: make getDevicePath more robust [cloudstack]

2024-06-06 Thread via GitHub
DaanHoogland commented on PR #9143: URL: https://github.com/apache/cloudstack/pull/9143#issuecomment-2151820984 @rp- , I had some problems merging this forward. Can you review the merge commit https://github.com/apache/cloudstack/commit/c779b1c616471b8fea833c4b090a7f3bc2dc6ab7 , please?

Re: [PR] linstor: make getDevicePath more robust [cloudstack]

2024-06-06 Thread via GitHub
DaanHoogland merged PR #9143: URL: https://github.com/apache/cloudstack/pull/9143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] linstor: make getDevicePath more robust [cloudstack]

2024-06-05 Thread via GitHub
blueorangutan commented on PR #9143: URL: https://github.com/apache/cloudstack/pull/9143#issuecomment-2150962421 [SF] Trillian test result (tid-10359) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46157 seconds Marvin logs: https://github.co

Re: [PR] linstor: make getDevicePath more robust [cloudstack]

2024-06-05 Thread via GitHub
blueorangutan commented on PR #9143: URL: https://github.com/apache/cloudstack/pull/9143#issuecomment-2149110457 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] linstor: make getDevicePath more robust [cloudstack]

2024-06-05 Thread via GitHub
DaanHoogland commented on PR #9143: URL: https://github.com/apache/cloudstack/pull/9143#issuecomment-2149108004 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] linstor: make getDevicePath more robust [cloudstack]

2024-06-05 Thread via GitHub
blueorangutan commented on PR #9143: URL: https://github.com/apache/cloudstack/pull/9143#issuecomment-2149029868 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9786 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] linstor: make getDevicePath more robust [cloudstack]

2024-06-04 Thread via GitHub
rohityadavcloud commented on PR #9143: URL: https://github.com/apache/cloudstack/pull/9143#issuecomment-2148911840 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] linstor: make getDevicePath more robust [cloudstack]

2024-06-04 Thread via GitHub
blueorangutan commented on PR #9143: URL: https://github.com/apache/cloudstack/pull/9143#issuecomment-2148912280 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progr

Re: [PR] linstor: make getDevicePath more robust [cloudstack]

2024-05-29 Thread via GitHub
JoaoJandre commented on code in PR #9143: URL: https://github.com/apache/cloudstack/pull/9143#discussion_r1618917914 ## plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/datastore/util/LinstorUtil.java: ## @@ -109,4 +110,36 @@ public static boolean isRes

Re: [PR] linstor: make getDevicePath more robust [cloudstack]

2024-05-29 Thread via GitHub
codecov[bot] commented on PR #9143: URL: https://github.com/apache/cloudstack/pull/9143#issuecomment-2137278162 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9143?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] linstor: make getDevicePath more robust [cloudstack]

2024-05-29 Thread via GitHub
rp- opened a new pull request, #9143: URL: https://github.com/apache/cloudstack/pull/9143 ### Description Before we only asked the first resource for the device path, if those resource was down or broken, we wouldn't get a device path at all. Now we go through all resource and use th