Re: [PR] fix: remove double element from 2FA form [cloudstack]

2024-12-02 Thread via GitHub
DaanHoogland merged PR #9851: URL: https://github.com/apache/cloudstack/pull/9851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] fix: remove double element from 2FA form [cloudstack]

2024-11-07 Thread via GitHub
phsm commented on PR #9851: URL: https://github.com/apache/cloudstack/pull/9851#issuecomment-2462339641 @rohityadavcloud I see you have made changes to this file in the past. Perhaps you can take a look? -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] fix: remove double element from 2FA form [cloudstack]

2024-11-07 Thread via GitHub
DaanHoogland commented on PR #9851: URL: https://github.com/apache/cloudstack/pull/9851#issuecomment-2462394949 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] fix: remove double element from 2FA form [cloudstack]

2024-11-07 Thread via GitHub
DaanHoogland commented on PR #9851: URL: https://github.com/apache/cloudstack/pull/9851#issuecomment-2462308903 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] fix: remove double element from 2FA form [cloudstack]

2024-11-07 Thread via GitHub
DaanHoogland commented on PR #9851: URL: https://github.com/apache/cloudstack/pull/9851#issuecomment-2462308672 > Hello, is there any progress with this PR? @phsm , the rule is two reviews of which at least one has done testing. So far I am the only one that has reviewed. You could as

Re: [PR] fix: remove double element from 2FA form [cloudstack]

2024-11-06 Thread via GitHub
phsm commented on PR #9851: URL: https://github.com/apache/cloudstack/pull/9851#issuecomment-2459677590 Hello, is there any progress with this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] fix: remove double element from 2FA form [cloudstack]

2024-10-28 Thread via GitHub
phsm commented on PR #9851: URL: https://github.com/apache/cloudstack/pull/9851#issuecomment-2442045702 > clgtm, I cannot see a functional difference in your video snippets (before/after) @phsm? Thanks for pointing that out. I indeed made it unclear. Replaced the first video.

Re: [PR] fix: remove double element from 2FA form [cloudstack]

2024-10-25 Thread via GitHub
blueorangutan commented on PR #9851: URL: https://github.com/apache/cloudstack/pull/9851#issuecomment-2435201767 UI build failed: :heavy_multiplication_x: (SL-JID-467) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[PR] fix: remove double element from 2FA form [cloudstack]

2024-10-25 Thread via GitHub
phsm opened a new pull request, #9851: URL: https://github.com/apache/cloudstack/pull/9851 ### Description This PR fixes the password managers autofill functionality in the 2FA OTP code form. It is caused by double `` element. Fixes: #9510 The PR simply remov

Re: [PR] fix: remove double element from 2FA form [cloudstack]

2024-10-25 Thread via GitHub
codecov[bot] commented on PR #9851: URL: https://github.com/apache/cloudstack/pull/9851#issuecomment-2435205810 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9851?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] fix: remove double element from 2FA form [cloudstack]

2024-10-25 Thread via GitHub
sureshanaparti commented on PR #9851: URL: https://github.com/apache/cloudstack/pull/9851#issuecomment-2435188847 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] fix: remove double element from 2FA form [cloudstack]

2024-10-24 Thread via GitHub
blueorangutan commented on PR #9851: URL: https://github.com/apache/cloudstack/pull/9851#issuecomment-2435190676 @sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] fix: remove double element from 2FA form [cloudstack]

2024-10-24 Thread via GitHub
blueorangutan commented on PR #9851: URL: https://github.com/apache/cloudstack/pull/9851#issuecomment-2435220431 UI build failed: :heavy_multiplication_x: (SL-JID-468) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] fix: remove double element from 2FA form [cloudstack]

2024-10-24 Thread via GitHub
sureshanaparti commented on PR #9851: URL: https://github.com/apache/cloudstack/pull/9851#issuecomment-2435207842 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] fix: remove double element from 2FA form [cloudstack]

2024-10-24 Thread via GitHub
blueorangutan commented on PR #9851: URL: https://github.com/apache/cloudstack/pull/9851#issuecomment-2435209113 @sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo