Re: [PR] extra null guard [cloudstack]

2025-01-27 Thread via GitHub
blueorangutan commented on PR #10264: URL: https://github.com/apache/cloudstack/pull/10264#issuecomment-2616938223 [SF] Trillian test result (tid-12190) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 46692 seconds Marvin logs: https://github.co

Re: [PR] extra null guard [cloudstack]

2025-01-27 Thread via GitHub
DaanHoogland merged PR #10264: URL: https://github.com/apache/cloudstack/pull/10264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [PR] extra null guard [cloudstack]

2025-01-27 Thread via GitHub
DaanHoogland commented on code in PR #10264: URL: https://github.com/apache/cloudstack/pull/10264#discussion_r1930509223 ## engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java: ## @@ -586,11 +586,11 @@ protected AgentAttache notifyMonitorsOfConnectio

Re: [PR] extra null guard [cloudstack]

2025-01-27 Thread via GitHub
hsato03 commented on code in PR #10264: URL: https://github.com/apache/cloudstack/pull/10264#discussion_r1930496749 ## engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java: ## @@ -586,11 +586,11 @@ protected AgentAttache notifyMonitorsOfConnection(fin

Re: [PR] extra null guard [cloudstack]

2025-01-27 Thread via GitHub
DaanHoogland commented on code in PR #10264: URL: https://github.com/apache/cloudstack/pull/10264#discussion_r1930479516 ## engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java: ## @@ -586,11 +586,11 @@ protected AgentAttache notifyMonitorsOfConnectio

Re: [PR] extra null guard [cloudstack]

2025-01-27 Thread via GitHub
hsato03 commented on code in PR #10264: URL: https://github.com/apache/cloudstack/pull/10264#discussion_r1930409414 ## engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java: ## @@ -586,11 +586,11 @@ protected AgentAttache notifyMonitorsOfConnection(fin

Re: [PR] extra null guard [cloudstack]

2025-01-26 Thread via GitHub
blueorangutan commented on PR #10264: URL: https://github.com/apache/cloudstack/pull/10264#issuecomment-2615054212 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond

Re: [PR] extra null guard [cloudstack]

2025-01-26 Thread via GitHub
DaanHoogland commented on PR #10264: URL: https://github.com/apache/cloudstack/pull/10264#issuecomment-2615051079 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] extra null guard [cloudstack]

2025-01-24 Thread via GitHub
blueorangutan commented on PR #10264: URL: https://github.com/apache/cloudstack/pull/10264#issuecomment-2613732276 [SF] Trillian test result (tid-12184) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 49795 seconds Marvin logs: https://github.co

Re: [PR] extra null guard [cloudstack]

2025-01-24 Thread via GitHub
blueorangutan commented on PR #10264: URL: https://github.com/apache/cloudstack/pull/10264#issuecomment-2612359245 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond

Re: [PR] extra null guard [cloudstack]

2025-01-24 Thread via GitHub
DaanHoogland commented on PR #10264: URL: https://github.com/apache/cloudstack/pull/10264#issuecomment-2612356944 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] extra null guard [cloudstack]

2025-01-24 Thread via GitHub
blueorangutan commented on PR #10264: URL: https://github.com/apache/cloudstack/pull/10264#issuecomment-2612338398 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] extra null guard [cloudstack]

2025-01-24 Thread via GitHub
codecov[bot] commented on PR #10264: URL: https://github.com/apache/cloudstack/pull/10264#issuecomment-2612248288 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10264?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

Re: [PR] extra null guard [cloudstack]

2025-01-24 Thread via GitHub
blueorangutan commented on PR #10264: URL: https://github.com/apache/cloudstack/pull/10264#issuecomment-2612237126 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] extra null guard [cloudstack]

2025-01-24 Thread via GitHub
DaanHoogland commented on PR #10264: URL: https://github.com/apache/cloudstack/pull/10264#issuecomment-2612235875 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[PR] extra null guard [cloudstack]

2025-01-24 Thread via GitHub
DaanHoogland opened a new pull request, #10264: URL: https://github.com/apache/cloudstack/pull/10264 ### Description This PR adds an extra null guard in notify monitors see the discussion in https://github.com/apache/cloudstack/pull/10158#discussion_r1928448081