Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-09-27 Thread via GitHub
blueorangutan commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2380407529 [SF] Trillian test result (tid-11568) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 51996 seconds Marvin logs: https://github.com/

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-09-25 Thread via GitHub
blueorangutan commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2374833231 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-09-25 Thread via GitHub
DaanHoogland commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2374699448 > > > > The issue is not resolved. When I try creating a site to site VPN connection without enabling the VPN gateway of the VPC it doesn't throw any error. > > > > > >

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-09-25 Thread via GitHub
blueorangutan commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2374709817 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-09-25 Thread via GitHub
DaanHoogland commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2374700690 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-09-23 Thread via GitHub
kiranchavala commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2367769383 > > > The issue is not resolved. When I try creating a site to site VPN connection without enabling the VPN gateway of the VPC it doesn't throw any error. > > > > > > h

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-07-18 Thread via GitHub
DaanHoogland commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2236529854 > > The issue is not resolved. When I try creating a site to site VPN connection without enabling the VPN gateway of the VPC it doesn't throw any error. > > hm, it has been

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-07-18 Thread via GitHub
blueorangutan commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2235874407 [SF] Trillian test result (tid-10901) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50177 seconds Marvin logs: https://github.co

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-07-17 Thread via GitHub
blueorangutan commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2233847653 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-07-17 Thread via GitHub
DaanHoogland commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2233845400 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-07-17 Thread via GitHub
blueorangutan commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2233559630 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10391 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-07-17 Thread via GitHub
blueorangutan commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2233417028 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-07-17 Thread via GitHub
DaanHoogland commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2233414193 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-07-17 Thread via GitHub
DaanHoogland commented on code in PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#discussion_r1681118396 ## server/src/main/java/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java: ## @@ -382,19 +407,15 @@ public boolean deleteCustomerGateway(DeleteVpnCustomerGate

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-07-17 Thread via GitHub
GaOrtiga commented on code in PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#discussion_r1681008587 ## server/src/main/java/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java: ## @@ -404,7 +425,7 @@ protected boolean doDeleteCustomerGateway(Site2SiteCustomerGatew

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-07-02 Thread via GitHub
blueorangutan commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2197790402 [SF] Trillian test result (tid-10678) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43357 seconds Marvin logs: https://github.co

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-06-24 Thread via GitHub
blueorangutan commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2186041226 Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10090 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-06-24 Thread via GitHub
blueorangutan commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2185831308 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-06-24 Thread via GitHub
sureshanaparti commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2185828149 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-06-22 Thread via GitHub
DaanHoogland commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2182757388 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-06-21 Thread via GitHub
blueorangutan commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2180585150 [SF] Trillian Build Failed (tid-10533) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-06-21 Thread via GitHub
blueorangutan commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2180549118 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-06-21 Thread via GitHub
DaanHoogland commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2180544830 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-06-18 Thread via GitHub
hsato03 commented on code in PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#discussion_r1644828016 ## server/src/main/java/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java: ## @@ -326,6 +315,46 @@ public Site2SiteVpnConnection createVpnConnection(CreateVpnConne

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2158466645 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9843 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2158275908 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-06-10 Thread via GitHub
DaanHoogland commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2158272635 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] cleanup validations for VPN connection creation [cloudstack]

2024-06-10 Thread via GitHub
codecov[bot] commented on PR #9195: URL: https://github.com/apache/cloudstack/pull/9195#issuecomment-2157718124 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9195?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] cleanup validations for VPN connection creation [cloudstack]

2024-06-10 Thread via GitHub
DaanHoogland opened a new pull request, #9195: URL: https://github.com/apache/cloudstack/pull/9195 ### Description This PR adds a validation when creating a VPN connection in a VPC to make sure the VPN gateway exists. Fixes: #7250