Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-05-22 Thread via GitHub
rohityadavcloud commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2124763220 As I don't care much for the PR anymore and #8782 has addressed most if not all my concerns, I'm closing this PR. I may raise a new PR for changes that aren't in #8782 and we p

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-05-22 Thread via GitHub
rohityadavcloud closed pull request #8985: api: improve listVM API handling and response speed URL: https://github.com/apache/cloudstack/pull/8985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-30 Thread via GitHub
rohityadavcloud commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2084766653 My bad I didn't look at prior work #8782 or remember what others have said on each and every other PRs. To be fair, I don't remember what I wrote on #8782 last month before I s

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-29 Thread via GitHub
GutoVeronezi commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2082487250 > At the time I couldn't co-relate what made the API slow only to later find out through community and customer issues who are facing degraded performance. That is the main

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-29 Thread via GitHub
blueorangutan commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2082208430 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9461 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-29 Thread via GitHub
blueorangutan commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2082091391 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progr

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-29 Thread via GitHub
rohityadavcloud commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2082087965 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-27 Thread via GitHub
blueorangutan commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2081162888 [SF] Trillian test result (tid-10065) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45766 seconds Marvin logs: https://github.co

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2080387194 @rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. T

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
rohityadavcloud commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2080386854 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2080382660 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9452 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2080362392 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progr

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
rohityadavcloud commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2080362124 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
rohityadavcloud commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2080360286 Thanks @weizhouapache @JoaoJandre I've addressed the feedback and comments. Joao's remarks are valid, however, my comments at the time were largely around metrics vs non-

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2080113463 [SF] Trillian test result (tid-10044) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43454 seconds Marvin logs: https://github.co

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
JoaoJandre commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2079269843 Hello @rohityadavcloud , @weizhouapache Looking briefly at this PR I noticed that it has a big intersection with #8782, especially the changes on the listVirtualMachines and

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
codecov-commenter commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2078915556 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8985?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+com

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2078893304 @rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. T

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
rohityadavcloud commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2078889488 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2078875541 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9435 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2078756605 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progr

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
rohityadavcloud commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2078755984 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
rohityadavcloud opened a new pull request, #8985: URL: https://github.com/apache/cloudstack/pull/8985 - Changes behaviour of details param handling for: - listVirtualMachines API: when the detail param is not provided, it uses `all` details except `stats` - listVirtualMachinesMetri