Re: [PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-19 Thread via GitHub
JoaoJandre merged PR #8787: URL: https://github.com/apache/cloudstack/pull/8787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@clou

Re: [PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-19 Thread via GitHub
KlausDornsbach commented on PR #8787: URL: https://github.com/apache/cloudstack/pull/8787#issuecomment-2007752698 Tested as described on #8729 without and with the changes in this PR: Running the version without changes, I sent packets to the public IP address at port 35999 of the a newly

Re: [PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-19 Thread via GitHub
KlausDornsbach commented on PR #8787: URL: https://github.com/apache/cloudstack/pull/8787#issuecomment-2007437855 Tested and clgtm @JoaoJandre -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-18 Thread via GitHub
JoaoJandre commented on PR #8787: URL: https://github.com/apache/cloudstack/pull/8787#issuecomment-2004503876 @KlausDornsbach could you test this and share your test steps/results? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-15 Thread via GitHub
weizhouapache commented on PR #8787: URL: https://github.com/apache/cloudstack/pull/8787#issuecomment-2000329550 @JoaoJandre please test it by yourself or ask someone else to test it. It is required to test it manually (except the author) -- This is an automated message from the Apa

Re: [PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-15 Thread via GitHub
weizhouapache commented on PR #8787: URL: https://github.com/apache/cloudstack/pull/8787#issuecomment-2000326676 > @weizhouapache does this still need work? Also, could you share your test results? here is the iptables rules of a VPC VR without any tier in my testing ``` root@r-

Re: [PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-15 Thread via GitHub
JoaoJandre commented on PR #8787: URL: https://github.com/apache/cloudstack/pull/8787#issuecomment-207779 @weizhouapache does this still need work? Also, could you share your test results? -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-15 Thread via GitHub
DaanHoogland commented on PR #8787: URL: https://github.com/apache/cloudstack/pull/8787#issuecomment-107841 @JoaoJandre , please merge at your will -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-14 Thread via GitHub
blueorangutan commented on PR #8787: URL: https://github.com/apache/cloudstack/pull/8787#issuecomment-1998611573 [SF] Trillian test result (tid-9473) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46293 seconds Marvin logs: https://github.com

Re: [PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-14 Thread via GitHub
blueorangutan commented on PR #8787: URL: https://github.com/apache/cloudstack/pull/8787#issuecomment-1998544224 [SF] Trillian test result (tid-9472) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 42659 seconds Marvin logs: https://github.co

Re: [PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-14 Thread via GitHub
blueorangutan commented on PR #8787: URL: https://github.com/apache/cloudstack/pull/8787#issuecomment-1998509615 [SF] Trillian test result (tid-9471) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41029 seconds Marvin logs: https://github.co

Re: [PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-14 Thread via GitHub
blueorangutan commented on PR #8787: URL: https://github.com/apache/cloudstack/pull/8787#issuecomment-1997028913 @weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This

Re: [PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-14 Thread via GitHub
weizhouapache commented on PR #8787: URL: https://github.com/apache/cloudstack/pull/8787#issuecomment-1997024652 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-14 Thread via GitHub
blueorangutan commented on PR #8787: URL: https://github.com/apache/cloudstack/pull/8787#issuecomment-1996968085 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8933 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-14 Thread via GitHub
codecov[bot] commented on PR #8787: URL: https://github.com/apache/cloudstack/pull/8787#issuecomment-1996932890 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8787?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-14 Thread via GitHub
blueorangutan commented on PR #8787: URL: https://github.com/apache/cloudstack/pull/8787#issuecomment-1996807807 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

Re: [PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-14 Thread via GitHub
weizhouapache commented on PR #8787: URL: https://github.com/apache/cloudstack/pull/8787#issuecomment-1996801405 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-14 Thread via GitHub
weizhouapache opened a new pull request, #8787: URL: https://github.com/apache/cloudstack/pull/8787 ### Description This PR fixes #8729 ### Types of changes - [ ] Breaking change (fix or feature that would cause exis