Re: [PR] UI assorted fixes [cloudstack]

2024-07-14 Thread via GitHub
rohityadavcloud merged PR #9381: URL: https://github.com/apache/cloudstack/pull/9381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] UI assorted fixes [cloudstack]

2024-07-14 Thread via GitHub
rohityadavcloud commented on PR #9381: URL: https://github.com/apache/cloudstack/pull/9381#issuecomment-2227667398 @DaanHoogland as the copy button isn't what most people want (they could just click the console button), I find that duplicated and annoying; so only keep the button in the ac

Re: [PR] UI assorted fixes [cloudstack]

2024-07-12 Thread via GitHub
DaanHoogland commented on PR #9381: URL: https://github.com/apache/cloudstack/pull/9381#issuecomment-2225262403 works in FF and Chrome, but I don't think we need remove the copy console button here: ![image](https://github.com/user-attachments/assets/30903585-0069-4fcc-beab-3514e18e3b75

Re: [PR] UI assorted fixes [cloudstack]

2024-07-12 Thread via GitHub
blueorangutan commented on PR #9381: URL: https://github.com/apache/cloudstack/pull/9381#issuecomment-2225237982 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9381 (QA-JID-402) -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] UI assorted fixes [cloudstack]

2024-07-12 Thread via GitHub
codecov[bot] commented on PR #9381: URL: https://github.com/apache/cloudstack/pull/9381#issuecomment-2225221168 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9381?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] UI assorted fixes [cloudstack]

2024-07-12 Thread via GitHub
DaanHoogland commented on PR #9381: URL: https://github.com/apache/cloudstack/pull/9381#issuecomment-2225218035 looks generally good, will test in FF and Chrome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] UI assorted fixes [cloudstack]

2024-07-12 Thread via GitHub
DaanHoogland commented on code in PR #9381: URL: https://github.com/apache/cloudstack/pull/9381#discussion_r1675602163 ## ui/src/components/widgets/Console.vue: ## @@ -56,17 +56,10 @@ export default { this.url = (json && json.createconsoleendpointresponse) ? json.creat

Re: [PR] UI assorted fixes [cloudstack]

2024-07-12 Thread via GitHub
DaanHoogland commented on code in PR #9381: URL: https://github.com/apache/cloudstack/pull/9381#discussion_r1675602163 ## ui/src/components/widgets/Console.vue: ## @@ -56,17 +56,10 @@ export default { this.url = (json && json.createconsoleendpointresponse) ? json.creat

Re: [PR] UI assorted fixes [cloudstack]

2024-07-12 Thread via GitHub
blueorangutan commented on PR #9381: URL: https://github.com/apache/cloudstack/pull/9381#issuecomment-2225209379 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] UI assorted fixes [cloudstack]

2024-07-12 Thread via GitHub
rohityadavcloud commented on PR #9381: URL: https://github.com/apache/cloudstack/pull/9381#issuecomment-2225207206 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] UI assorted fixes [cloudstack]

2024-07-12 Thread via GitHub
rohityadavcloud opened a new pull request, #9381: URL: https://github.com/apache/cloudstack/pull/9381 UI fixes to address missing useful columns and fixes copy console button. Remove unnecessary copy button on info card that looks congested and confusing. ### Types of changes