weizhouapache commented on PR #8593:
URL: https://github.com/apache/cloudstack/pull/8593#issuecomment-2082191087
Merging
thanks @DaanHoogland @vishesh92 for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
weizhouapache merged PR #8593:
URL: https://github.com/apache/cloudstack/pull/8593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@c
blueorangutan commented on PR #8593:
URL: https://github.com/apache/cloudstack/pull/8593#issuecomment-2074261381
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8593 (QA-JID-319)
--
This is an automated message from the Apache Git Service.
To respond t
blueorangutan commented on PR #8593:
URL: https://github.com/apache/cloudstack/pull/8593#issuecomment-2074234333
@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep
you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respon
weizhouapache commented on PR #8593:
URL: https://github.com/apache/cloudstack/pull/8593#issuecomment-2074233270
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
DaanHoogland closed pull request #8593: UI: hide Cleanup/Expunge when delete a
CloudManaged CKS cluster
URL: https://github.com/apache/cloudstack/pull/8593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
blueorangutan commented on PR #8593:
URL: https://github.com/apache/cloudstack/pull/8593#issuecomment-1929189391
@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep
you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respon
weizhouapache commented on PR #8593:
URL: https://github.com/apache/cloudstack/pull/8593#issuecomment-1929188713
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
weizhouapache commented on PR #8593:
URL: https://github.com/apache/cloudstack/pull/8593#issuecomment-1927819457
> clgtm.
>
> @weizhouapache There is an additional commit from #8482. Can you please
remove that?
thanks for review @vishesh92
it does not matter actually, as 4.
blueorangutan commented on PR #8593:
URL: https://github.com/apache/cloudstack/pull/8593#issuecomment-1927086476
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8593:
URL: https://github.com/apache/cloudstack/pull/8593#issuecomment-1926957797
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progres
weizhouapache commented on PR #8593:
URL: https://github.com/apache/cloudstack/pull/8593#issuecomment-1926953795
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
blueorangutan commented on PR #8593:
URL: https://github.com/apache/cloudstack/pull/8593#issuecomment-1926733638
Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8593:
URL: https://github.com/apache/cloudstack/pull/8593#issuecomment-1926681972
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progres
weizhouapache commented on PR #8593:
URL: https://github.com/apache/cloudstack/pull/8593#issuecomment-1926648116
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
weizhouapache commented on PR #8593:
URL: https://github.com/apache/cloudstack/pull/8593#issuecomment-1925251142
> Code looks good @weizhouapache , but what is the reason?
> And if we want this don't we want to prevent it on the API?
@DaanHoogland
Destroy/expunge are only applic
DaanHoogland commented on PR #8593:
URL: https://github.com/apache/cloudstack/pull/8593#issuecomment-1925207767
Code looks good @weizhouapache , but what is the reason?
And if we want this don't we want to prevent it on the API?
--
This is an automated message from the Apache Git Servic
codecov[bot] commented on PR #8593:
URL: https://github.com/apache/cloudstack/pull/8593#issuecomment-1921396502
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8593?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
weizhouapache opened a new pull request, #8593:
URL: https://github.com/apache/cloudstack/pull/8593
### Description
This PR hides the destroy/expunge option for CloudManaged CKS cluster
prior to this change
