DaanHoogland merged PR #8792:
URL: https://github.com/apache/cloudstack/pull/8792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cl
DaanHoogland commented on PR #8792:
URL: https://github.com/apache/cloudstack/pull/8792#issuecomment-2066193931
tested in qa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
blueorangutan commented on PR #8792:
URL: https://github.com/apache/cloudstack/pull/8792#issuecomment-2066176068
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8792 (QA-JID-317)
--
This is an automated message from the Apache Git Service.
To respond t
DaanHoogland commented on PR #8792:
URL: https://github.com/apache/cloudstack/pull/8792#issuecomment-2066151781
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
blueorangutan commented on PR #8792:
URL: https://github.com/apache/cloudstack/pull/8792#issuecomment-2066153815
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep
you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond
codecov-commenter commented on PR #8792:
URL: https://github.com/apache/cloudstack/pull/8792#issuecomment-2066150651
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8792?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+com
vishesh92 commented on code in PR #8792:
URL: https://github.com/apache/cloudstack/pull/8792#discussion_r1528671141
##
ui/src/components/widgets/Status.vue:
##
@@ -166,23 +166,24 @@ export default {
if (!(state && this.displayText)) {
return ''
}
Review C
DaanHoogland commented on code in PR #8792:
URL: https://github.com/apache/cloudstack/pull/8792#discussion_r1526453967
##
ui/src/components/widgets/Status.vue:
##
@@ -166,23 +166,24 @@ export default {
if (!(state && this.displayText)) {
return ''
}
Revie
codecov[bot] commented on PR #8792:
URL: https://github.com/apache/cloudstack/pull/8792#issuecomment-1998433705
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8792?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
blueorangutan commented on PR #8792:
URL: https://github.com/apache/cloudstack/pull/8792#issuecomment-1998325741
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8792 (QA-JID-301)
--
This is an automated message from the Apache Git Service.
To respond t
blueorangutan commented on PR #8792:
URL: https://github.com/apache/cloudstack/pull/8792#issuecomment-1998308691
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you
posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to
vishesh92 commented on PR #8792:
URL: https://github.com/apache/cloudstack/pull/8792#issuecomment-1998307703
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
vishesh92 opened a new pull request, #8792:
URL: https://github.com/apache/cloudstack/pull/8792
### Description
This PR fixes #8783. Status widget changes the tooltip message based on the
url. To fix this, before returning the tooltip message, we check if there is no
string available
13 matches
Mail list logo
