weizhouapache commented on PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791#issuecomment-2175723629
> @weizhouapache is this ok by you? or else what still needs to be done ? cc
@Pearl1594 ?
@DaanHoogland @Pearl1594
verified ok
- create a user data with "hah
weizhouapache merged PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@c
weizhouapache commented on PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791#issuecomment-2175724016
thanks @Pearl1594 , merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
DaanHoogland commented on PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791#issuecomment-2175531867
@weizhouapache is this ok by you? or else what still needs to be done ? cc
@Pearl1594 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
Pearl1594 commented on code in PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791#discussion_r1620460659
##
ui/src/utils/plugins.js:
##
@@ -490,8 +499,7 @@ export const genericUtilPlugin = {
}
app.config.globalProperties.$toBase64AndURIEncoded = function (
shwstppr commented on code in PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791#discussion_r1620255651
##
ui/src/utils/plugins.js:
##
@@ -490,8 +499,7 @@ export const genericUtilPlugin = {
}
app.config.globalProperties.$toBase64AndURIEncoded = function (t
Pearl1594 commented on code in PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791#discussion_r1526368044
##
ui/src/utils/plugins.js:
##
@@ -490,8 +499,7 @@ export const genericUtilPlugin = {
}
app.config.globalProperties.$toBase64AndURIEncoded = function (
weizhouapache commented on code in PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791#discussion_r1526235912
##
ui/src/utils/plugins.js:
##
@@ -490,8 +499,7 @@ export const genericUtilPlugin = {
}
app.config.globalProperties.$toBase64AndURIEncoded = functi
weizhouapache commented on code in PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791#discussion_r1526218947
##
ui/src/utils/plugins.js:
##
@@ -490,8 +499,7 @@ export const genericUtilPlugin = {
}
app.config.globalProperties.$toBase64AndURIEncoded = functi
Pearl1594 commented on code in PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791#discussion_r1526190752
##
ui/src/utils/plugins.js:
##
@@ -490,8 +499,7 @@ export const genericUtilPlugin = {
}
app.config.globalProperties.$toBase64AndURIEncoded = function (
weizhouapache commented on code in PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791#discussion_r1526044811
##
ui/src/utils/plugins.js:
##
@@ -490,8 +499,7 @@ export const genericUtilPlugin = {
}
app.config.globalProperties.$toBase64AndURIEncoded = functi
weizhouapache commented on PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791#issuecomment-1998069746
> Ok got it, I'll add a checkbox that will only be used by the ui to
determine whether to encode the provided userdata or not..
good ,looking forward to it
--
This is an
Pearl1594 commented on PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791#issuecomment-1998061391
Ok got it, I'll add a checkbox that will only be used by the ui to determine
whether to encode the provided userdata or not..
--
This is an automated message from the Apache Git S
weizhouapache commented on PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791#issuecomment-1998055575
> @weizhouapache sorry I didn't quite understand why the gzip in between.
refer to
https://cloudinit.readthedocs.io/en/latest/explanation/format.html#gzip-compressed-conte
Pearl1594 commented on PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791#issuecomment-1997986975
@weizhouapache sorry I didn't quite understand why the gzip in between.
Because without it i.e., `echo "Apache CloudStack" | base64 -w0` if this is
provided as input to the userdat
weizhouapache commented on PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791#issuecomment-1997710164
> @weizhouapache we could - do you mean that users would need to specify if
its encoded or not? If so, wouldn't it be user friendly if we have the code
decide if it's encoded or
Pearl1594 commented on PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791#issuecomment-1997692496
@weizhouapache we could - do you mean that users would need to specify if
its encoded or not? If so, wouldn't it be user friendly if we have the code
decide if it's encoded or not an
weizhouapache commented on PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791#issuecomment-1997682818
@Pearl1594
what do you think if we add a checkbox to indicate if userdata is
base64-encoded ?
for example
