Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-06-24 Thread via GitHub
blueorangutan commented on PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#issuecomment-2185821124 @rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. T

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-06-24 Thread via GitHub
rohityadavcloud commented on PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#issuecomment-2185820307 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-06-23 Thread via GitHub
blueorangutan commented on PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#issuecomment-2185160871 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10079 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-06-23 Thread via GitHub
sureshanaparti commented on PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#issuecomment-2185105949 Hi @slavkap Please check/address the comments. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-06-23 Thread via GitHub
sureshanaparti commented on code in PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#discussion_r1650115706 ## plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/driver/StorPoolStatsCollector.java: ## @@ -185,4 +205,90 @@ private v

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-06-23 Thread via GitHub
sureshanaparti commented on code in PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#discussion_r1650115152 ## plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/snapshot/StorPoolConfigurationManager.java: ## @@ -44,13 +44,23 @@ public class

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-06-23 Thread via GitHub
sureshanaparti commented on code in PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#discussion_r1650113723 ## engine/schema/src/main/java/com/cloud/storage/dao/SnapshotDetailsDaoImpl.java: ## @@ -18,11 +18,44 @@ */ package com.cloud.storage.dao; +import java.s

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-06-23 Thread via GitHub
blueorangutan commented on PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#issuecomment-2185097930 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-06-23 Thread via GitHub
sureshanaparti commented on PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#issuecomment-2185096125 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-04-12 Thread via GitHub
blueorangutan commented on PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#issuecomment-2051370769 [SF] Trillian Build Failed (tid-9807) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-04-12 Thread via GitHub
blueorangutan commented on PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#issuecomment-2051324878 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-04-12 Thread via GitHub
DaanHoogland commented on PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#issuecomment-2051322433 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-04-12 Thread via GitHub
blueorangutan commented on PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#issuecomment-2051309215 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9233 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-04-12 Thread via GitHub
blueorangutan commented on PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#issuecomment-2051196396 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-04-12 Thread via GitHub
DaanHoogland commented on PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#issuecomment-2051194656 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-04-11 Thread via GitHub
slavkap commented on code in PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#discussion_r1561040808 ## plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/driver/StorPoolStatsCollector.java: ## @@ -70,7 +86,7 @@ enum StorPoolObject

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-04-11 Thread via GitHub
slavkap commented on code in PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#discussion_r1561037449 ## plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/driver/StorPoolPrimaryDataStoreDriver.java: ## @@ -431,6 +439,54 @@ public v

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-04-08 Thread via GitHub
sureshanaparti commented on code in PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#discussion_r1555718413 ## engine/schema/src/main/java/com/cloud/storage/dao/SnapshotDetailsDaoImpl.java: ## @@ -18,11 +18,44 @@ */ package com.cloud.storage.dao; +import java.s

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-04-08 Thread via GitHub
sureshanaparti commented on code in PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#discussion_r1555716862 ## plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/driver/StorPoolStatsCollector.java: ## @@ -185,4 +205,90 @@ private v

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-04-08 Thread via GitHub
sureshanaparti commented on code in PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#discussion_r1555713980 ## plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/driver/StorPoolStatsCollector.java: ## @@ -70,7 +86,7 @@ enum StorPoo

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-04-08 Thread via GitHub
sureshanaparti commented on code in PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#discussion_r1555708565 ## plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/driver/StorPoolPrimaryDataStoreDriver.java: ## @@ -431,6 +439,54 @@ p

Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-03-28 Thread via GitHub
codecov[bot] commented on PR #8843: URL: https://github.com/apache/cloudstack/pull/8843#issuecomment-2024920267 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8843?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] Temporarily backup StorPool volume before expunge [cloudstack]

2024-03-28 Thread via GitHub
slavkap opened a new pull request, #8843: URL: https://github.com/apache/cloudstack/pull/8843 ### Description Sometimes the users delete the volumes by mistake. This enhancement provides a solution to backup the volume before it's deleted. The user will be able to see the snapshot in