Re: [PR] StoragePoolType as class [cloudstack]

rohityadavcloud merged PR #8544: URL: https://github.com/apache/cloudstack/pull/8544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1916073222 [SF] Trillian test result (tid-8979) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 49449 seconds Marvin logs: https://github.co

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1915993713 [SF] Trillian test result (tid-8977) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43297 seconds Marvin logs: https://github.co

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1914829683 @sureshanaparti a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This

Re: [PR] StoragePoolType as class [cloudstack]

sureshanaparti commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1914826740 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1914674688 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8462 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1914571498 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] StoragePoolType as class [cloudstack]

sureshanaparti commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1914568414 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1909138116 [SF] Trillian test result (tid-8932) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 54034 seconds Marvin logs: https://github.co

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1909007942 [SF] Trillian test result (tid-8934) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46844 seconds Marvin logs: https://github.com

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1907867517 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8431 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1907749634 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] StoragePoolType as class [cloudstack]

sureshanaparti commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1907718702 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] StoragePoolType as class [cloudstack]

sureshanaparti commented on code in PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#discussion_r1464590405 ## framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java: ## @@ -650,7 +655,7 @@ protected void setField(Object entity, Field field, ResultSet rs

Re: [PR] StoragePoolType as class [cloudstack]

sureshanaparti commented on code in PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#discussion_r1464583628 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java: ## @@ -775,23 +781,22 @@ public KVMPhysicalDisk createPh

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1907665475 @rohityadavcloud a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- Thi

Re: [PR] StoragePoolType as class [cloudstack]

rohityadavcloud commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1907664023 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1907069371 [SF] Trillian test result (tid-8912) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48318 seconds Marvin logs: https://github.com

Re: [PR] StoragePoolType as class [cloudstack]

DaanHoogland commented on code in PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#discussion_r1463068092 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java: ## @@ -775,23 +781,22 @@ public KVMPhysicalDisk createPhys

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1905625401 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] StoragePoolType as class [cloudstack]

sureshanaparti commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1905604401 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1905576509 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8413 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1905462699 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] StoragePoolType as class [cloudstack]

sureshanaparti commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1905460313 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1905005826 [SF] Trillian test result (tid-8897) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49345 seconds Marvin logs: https://github.co

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1904972150 [SF] Trillian test result (tid-8898) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 47652 seconds Marvin logs: https://github.co

Re: [PR] StoragePoolType as class [cloudstack]

sureshanaparti commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1903654103 > good functionality @sureshanaparti , I haven't looked at the code yet, but good to see movements like this, making ACS more configurable/extensible(/expandable?) thanks

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1903652398 [SF] Trillian Build Failed (tid-8899) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] StoragePoolType as class [cloudstack]

DaanHoogland commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1903613306 good functionality @sureshanaparti , I haven't looked at the code yet, but good to see movements like this, making ACS more configurable/extensible(/expandable?) -- This is an

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1903552164 @kiranchavala a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This i

Re: [PR] StoragePoolType as class [cloudstack]

kiranchavala commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1903551689 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1903500144 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8404 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] StoragePoolType as class [cloudstack]

codecov[bot] commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1903425186 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8544?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] StoragePoolType as class [cloudstack]

blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1903417376 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] StoragePoolType as class [cloudstack]

sureshanaparti commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1903415237 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[PR] StoragePoolType as class [cloudstack]

sureshanaparti opened a new pull request, #8544: URL: https://github.com/apache/cloudstack/pull/8544 ### Description This PR moves the StoragePoolType from an Enum to a class that is largely compatible with Enum. This allows for storage pool plugins to be added dynamically without ne