Re: [PR] Restrict the migration of volumes attached to VMs in Starting state [cloudstack]

2025-01-07 Thread via GitHub
DaanHoogland merged PR #9725: URL: https://github.com/apache/cloudstack/pull/9725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] Restrict the migration of volumes attached to VMs in Starting state [cloudstack]

2025-01-07 Thread via GitHub
blueorangutan commented on PR #9725: URL: https://github.com/apache/cloudstack/pull/9725#issuecomment-2576458590 [SF] Trillian test result (tid-12056) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 45617 seconds Marvin logs: https://github.com/

Re: [PR] Restrict the migration of volumes attached to VMs in Starting state [cloudstack]

2025-01-07 Thread via GitHub
blueorangutan commented on PR #9725: URL: https://github.com/apache/cloudstack/pull/9725#issuecomment-2574972575 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Restrict the migration of volumes attached to VMs in Starting state [cloudstack]

2025-01-07 Thread via GitHub
DaanHoogland commented on PR #9725: URL: https://github.com/apache/cloudstack/pull/9725#issuecomment-2574967970 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Restrict the migration of volumes attached to VMs in Starting state [cloudstack]

2025-01-07 Thread via GitHub
blueorangutan commented on PR #9725: URL: https://github.com/apache/cloudstack/pull/9725#issuecomment-2574931942 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Restrict the migration of volumes attached to VMs in Starting state [cloudstack]

2025-01-07 Thread via GitHub
blueorangutan commented on PR #9725: URL: https://github.com/apache/cloudstack/pull/9725#issuecomment-2574774951 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Restrict the migration of volumes attached to VMs in Starting state [cloudstack]

2025-01-07 Thread via GitHub
DaanHoogland commented on PR #9725: URL: https://github.com/apache/cloudstack/pull/9725#issuecomment-2574771234 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Restrict the migration of volumes attached to VMs in Starting state [cloudstack]

2025-01-06 Thread via GitHub
bernardodemarco commented on PR #9725: URL: https://github.com/apache/cloudstack/pull/9725#issuecomment-2573005984 > Yes, no problem. I'll update the verification to only allow the migration to be performed when the VM is Running, Stopped or Shutdown. @DaanHoogland, @rohityadavcloud,

Re: [PR] Restrict the migration of volumes attached to VMs in Starting state [cloudstack]

2025-01-03 Thread via GitHub
bernardodemarco commented on PR #9725: URL: https://github.com/apache/cloudstack/pull/9725#issuecomment-2569607448 > @DaanHoogland considering it's an easy change, I don't see why introduce this and change it later. Since @FelipeM525 is no longer working on this PR: @bernardodemarco could y

Re: [PR] Restrict the migration of volumes attached to VMs in Starting state [cloudstack]

2025-01-03 Thread via GitHub
JoaoJandre commented on PR #9725: URL: https://github.com/apache/cloudstack/pull/9725#issuecomment-2569344644 @DaanHoogland considering it's an easy change, I don't see why introduce this and change it later. Since @FelipeM525 is no longer working on this PR: @bernardodemarco could you

Re: [PR] Restrict the migration of volumes attached to VMs in Starting state [cloudstack]

2025-01-03 Thread via GitHub
DaanHoogland commented on PR #9725: URL: https://github.com/apache/cloudstack/pull/9725#issuecomment-2569224407 thanks @bernardodemarco @JoaoJandre , do you agree that this PR is good to go, even when more improvements are possible? -- This is an automated message from the Apache

Re: [PR] Restrict the migration of volumes attached to VMs in Starting state [cloudstack]

2024-11-07 Thread via GitHub
DaanHoogland commented on PR #9725: URL: https://github.com/apache/cloudstack/pull/9725#issuecomment-2462341559 > Is there any other state that we should be checking besides starting? migrating, for example? Good point, though this is already an improvement; ``` Starting

Re: [PR] Restrict the migration of volumes attached to VMs in Starting state [cloudstack]

2024-09-24 Thread via GitHub
codecov[bot] commented on PR #9725: URL: https://github.com/apache/cloudstack/pull/9725#issuecomment-2371865443 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9725?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] Restrict the migration of volumes attached to VMs in Starting state [cloudstack]

2024-09-24 Thread via GitHub
FelipeM525 opened a new pull request, #9725: URL: https://github.com/apache/cloudstack/pull/9725 ### Description This PR restricts users from migrating volumes attached to VMs that are in starting state. Migrating volumes while their VMs are starting shouldn't be allowed because som