JoaoJandre commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2334105306
Merging based on approvals and manual testing
https://github.com/apache/cloudstack/pull/9107#issuecomment-2305311036
--
This is an automated message from the Apache Git Service.
T
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2328957783
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
winterhazel commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2328950352
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
github-actions[bot] commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2328262075
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2310136089
@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To r
DaanHoogland commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2310134287
@blueorangutan LLtest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2309736354
[SF] Trillian Build Failed (tid-11181)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2309729231
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been
kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond t
DaanHoogland commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2309725192
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2307938498
[SF] Trillian test result (tid-11158)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53213 seconds
Marvin logs:
https://github.com/
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2306577522
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been
kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond t
DaanHoogland commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2306574218
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2305608901
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2305511994
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
winterhazel commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2305510637
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
winterhazel commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2305510108
Thanks for testing @JoaoJandre. I addressed the issue you pointed out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
winterhazel commented on code in PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#discussion_r1727676781
##
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##
@@ -1211,132 +1215,142 @@ protected String validateConfigurationValue(final
St
JoaoJandre commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2305311036
Hey @winterhazel
I did some testing, overall it looks good, but I've found one case that I
think we should address in this PR.
| Number | Config | Value | Result |
|
hsato03 commented on code in PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#discussion_r1727474012
##
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##
@@ -1211,132 +1215,142 @@ protected String validateConfigurationValue(final
String
hsato03 commented on code in PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#discussion_r1727461563
##
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##
@@ -1211,132 +1215,142 @@ protected String validateConfigurationValue(final
String
hsato03 commented on code in PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#discussion_r1727461563
##
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##
@@ -1211,132 +1215,142 @@ protected String validateConfigurationValue(final
String
JoaoJandre commented on code in PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#discussion_r1727039772
##
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##
@@ -1211,132 +1215,142 @@ protected String validateConfigurationValue(final
Str
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2284043258
[SF] Trillian Build Failed (tid-11061)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2283940067
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been
kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond t
DaanHoogland commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2283939173
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2283830114
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2283678305
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress
DaanHoogland commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2283675028
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
winterhazel opened a new pull request, #9107:
URL: https://github.com/apache/cloudstack/pull/9107
### Description
The configuration update process mixes type validation with range validation
in
`com.cloud.configuration.ConfigurationManagerImpl#validateConfigurationValue`.
To improve
DaanHoogland closed pull request #9107: Refactor type and range validation in
configuration update process
URL: https://github.com/apache/cloudstack/pull/9107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2250279693
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2250147951
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
winterhazel commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2250147124
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2200101098
Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
github-actions[bot] commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2197856115
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2194755006
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
winterhazel commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2194582900
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2194586425
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
codecov[bot] commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2168595317
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9107?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
hsato03 commented on code in PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#discussion_r1640203662
##
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##
@@ -682,9 +682,8 @@ public boolean stop() {
@DB
public String updateConfi
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2124803001
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2124629678
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
winterhazel commented on PR #9107:
URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2124625605
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
winterhazel opened a new pull request, #9107:
URL: https://github.com/apache/cloudstack/pull/9107
### Description
The configuration update process mixes type validation with range validation
in
`com.cloud.configuration.ConfigurationManagerImpl#validateConfigurationValue`.
To improve
44 matches
Mail list logo
