DaanHoogland merged PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cl
blueorangutan commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2227297553
[SF] Trillian test result (tid-10824)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 51626 seconds
Marvin logs:
https://github.com
blueorangutan commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2227074541
@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has
been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respo
DaanHoogland commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2227071761
@blueorangutan test alma9 kvm-alma9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
blueorangutan commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2226730936
[SF] Trillian test result (tid-10811)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 65827 seconds
Marvin logs:
https://github.co
blueorangutan commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2225040894
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To r
DaanHoogland commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2225039033
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
DaanHoogland commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2225038891
> [SF] Trillian test result (tid-10803) Environment: kvm-centos7 (x2),
Advanced Networking with Mgmt server 7 Total time taken: 57235 seconds Marvin
logs:
https://github.com/blue
blueorangutan commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2224347613
[SF] Trillian test result (tid-10803)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 57235 seconds
Marvin logs:
https://github.co
bernardodemarco commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2224081948
@JoaoJandre, once this PR gets merged, I intend to add UI support for the
position parameter on #9225.
--
This is an automated message from the Apache Git Service.
To respond
blueorangutan commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-626706
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To r
DaanHoogland commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-624322
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
blueorangutan commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2219904427
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2219751981
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress
DaanHoogland commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2219750524
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
github-actions[bot] commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2166673372
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
DaanHoogland commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2162596488
@JoaoJandre we are prioritising 4.19 now. /me postponing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
JoaoJandre commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2161151487
@DaanHoogland @sureshanaparti @rohityadavcloud could we run the CI here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
blueorangutan commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2160666807
Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2160518905
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
JoaoJandre commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2160510386
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
github-actions[bot] commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2144358221
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
github-actions[bot] commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2139729457
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
github-actions[bot] commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2134470514
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
DaanHoogland closed pull request #8347: Quota tariff order
URL: https://github.com/apache/cloudstack/pull/8347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
JoaoJandre opened a new pull request, #8347:
URL: https://github.com/apache/cloudstack/pull/8347
### Description
Quota tariffs have been extended to make it possible to define the order of
their execution. To achieve this, the `position` parameter was added to the
`quotaTariffCreate`
codecov-commenter commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2059576066
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8347?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+com
JoaoJandre commented on code in PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#discussion_r1562910276
##
framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaManagerImpl.java:
##
@@ -367,9 +369,22 @@ protected BigDecimal aggregateQuotaTariffsValues(Usage
hsato03 commented on code in PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#discussion_r1561549494
##
framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaManagerImpl.java:
##
@@ -367,9 +369,22 @@ protected BigDecimal aggregateQuotaTariffsValues(UsageVO
BryanMLima commented on code in PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#discussion_r1561536028
##
engine/schema/src/main/resources/META-INF/db/schema-41900to42000.sql:
##
@@ -79,3 +79,7 @@ CREATE TABLE IF NOT EXISTS
`cloud_usage`.`quota_email_configuration
JoaoJandre commented on code in PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#discussion_r1561533659
##
framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaManagerImpl.java:
##
@@ -367,9 +369,22 @@ protected BigDecimal aggregateQuotaTariffsValues(Usage
hsato03 commented on code in PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#discussion_r1561383592
##
framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaManagerImpl.java:
##
@@ -367,9 +369,22 @@ protected BigDecimal aggregateQuotaTariffsValues(UsageVO
blueorangutan commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2048329441
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2048213044
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
JoaoJandre commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-2048212606
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
DaanHoogland commented on code in PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#discussion_r1526466247
##
test/integration/plugins/test_quota_tariff_order.py:
##
@@ -0,0 +1,185 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributo
github-actions[bot] commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1998899302
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
blueorangutan commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1997540299
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1997393608
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
JoaoJandre commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1997391707
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
github-actions[bot] commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1994391386
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
github-actions[bot] commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1985459405
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
github-actions[bot] commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1964318755
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
DaanHoogland commented on code in PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#discussion_r1494265022
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffCreateCmd.java:
##
@@ -66,7 +66,7 @@ public class QuotaTariffCreateCmd exte
github-actions[bot] commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1952018376
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
JoaoJandre commented on code in PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#discussion_r1492904222
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffCreateCmd.java:
##
@@ -66,7 +66,7 @@ public class QuotaTariffCreateCmd extend
DaanHoogland commented on code in PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#discussion_r1492827492
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffUpdateCmd.java:
##
@@ -67,7 +67,7 @@ public class QuotaTariffUpdateCmd exte
blueorangutan commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1947575461
[SF] Trillian test result (tid-9227)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 55776 seconds
Marvin logs:
https://github.com/
GutoVeronezi commented on code in PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#discussion_r1491681359
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffUpdateCmd.java:
##
@@ -67,6 +67,9 @@ public class QuotaTariffUpdateCmd exte
blueorangutan commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1945632435
@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has
been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respo
DaanHoogland commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1945631951
@blueorangutan test alma9 kvm-alma9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
blueorangutan commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1944314955
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1944209051
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
JoaoJandre commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1944205535
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
github-actions[bot] commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1934110426
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
JoaoJandre commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1927391479
@DaanHoogland I've created the integration test. However, while testing it,
I found out that the test only works alongside #8581, thus, this PR now depends
on #8581.
--
This is a
github-actions[bot] commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1882870995
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
github-actions[bot] commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1859726118
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
JoaoJandre commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1853718711
> clgtm and well covered by tests, however as this is user facinng
functionality, doe sit make sense to add an integration test @JoaoJandre ?
Sure, I'll try to add some integr
codecov[bot] commented on PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1851882763
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8347?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
60 matches
Mail list logo
