JoaoJandre merged PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@clou
JoaoJandre commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-2003657468
Merging based on approvals, manual test results and CI results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
blueorangutan commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-2000349897
[SF] Trillian test result (tid-9489)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 53759 seconds
Marvin logs:
https://github.com
blueorangutan commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1998913442
@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has
been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respo
shwstppr commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1998913121
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
JoaoJandre commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1997851926
@DaanHoogland @rohityadavcloud @shwstppr could we run the CI on this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
blueorangutan commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1997540260
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1997393526
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
JoaoJandre commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1997392362
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
github-actions[bot] commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1994391343
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
github-actions[bot] commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1985459373
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
JoaoJandre commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1980852597
Thank you for testing @winterhazel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
winterhazel commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1979546446
I tested the feature introduced in this PR. It seems to be working as
intended.
First, I configured Quota to send e-mails. I also created an account with my
e-mail, added 9
github-actions[bot] commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1976512797
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
winterhazel commented on code in PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#discussion_r1509247066
##
engine/schema/src/main/resources/META-INF/db/schema-41900to42000.sql:
##
@@ -34,3 +34,12 @@ UPDATE `cloud`.`service_offering` SET ram_size = 512 WHERE
unique
BryanMLima commented on code in PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#discussion_r1508883903
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaConfigureEmailCmd.java:
##
@@ -0,0 +1,79 @@
+//Licensed to the Apache Software Foun
BryanMLima commented on code in PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#discussion_r1508141919
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaConfigureEmailCmd.java:
##
@@ -0,0 +1,79 @@
+//Licensed to the Apache Software Foun
JoaoJandre commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1971833414
@GutoVeronezi @BryanMLima @winterhazel Could someone review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
github-actions[bot] commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1964318715
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
blueorangutan commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1955078669
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1954942158
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
JoaoJandre commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1954939754
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
github-actions[bot] commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1952018339
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
GutoVeronezi commented on code in PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#discussion_r1491715284
##
framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java:
##
@@ -141,52 +146,72 @@ public boolean stop() {
@Override
pu
JoaoJandre commented on code in PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#discussion_r1487733347
##
framework/quota/src/main/java/org/apache/cloudstack/quota/dao/QuotaEmailConfigurationDaoImpl.java:
##
@@ -0,0 +1,132 @@
+// Licensed to the Apache Software Fou
github-actions[bot] commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1934110374
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
GutoVeronezi commented on code in PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#discussion_r1479862147
##
framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java:
##
@@ -143,52 +148,68 @@ public boolean stop() {
@Override
pu
github-actions[bot] commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1882870947
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
github-actions[bot] commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1859726092
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
codecov[bot] commented on PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1840856710
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8307?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
JoaoJandre opened a new pull request, #8307:
URL: https://github.com/apache/cloudstack/pull/8307
### Description
Currently, users have no control on whether they receive Quota emails or
not. If the Quota plugin is enabled, they will receive all applicable emails.
Furthermore, t
31 matches
Mail list logo
