Re: [PR] Prevent infinite retries of autoscaling [cloudstack]

2025-01-28 Thread via GitHub
btzq commented on PR #9574: URL: https://github.com/apache/cloudstack/pull/9574#issuecomment-2618603260 > @Pearl1594 I am ok with excluding the vms in Error state in the vm count. should we consider Stopped vms as available in the group ? > > my other advice would be > > * add

Re: [PR] Prevent infinite retries of autoscaling [cloudstack]

2025-01-21 Thread via GitHub
Pearl1594 commented on PR #9574: URL: https://github.com/apache/cloudstack/pull/9574#issuecomment-2605431214 I added Stopped State imagining a scenario where in say for whatever reason a host goes down, all VMs belonging to the autoscale group, on that host would enter stopped state. This w

Re: [PR] Prevent infinite retries of autoscaling [cloudstack]

2025-01-21 Thread via GitHub
weizhouapache commented on PR #9574: URL: https://github.com/apache/cloudstack/pull/9574#issuecomment-2604967576 @Pearl1594 I am ok with excluding the vms in Error state in the vm count. should we consider Stopped vms as available in the group ? my other advice would be - add

Re: [PR] Prevent infinite retries of autoscaling [cloudstack]

2024-08-23 Thread via GitHub
Pearl1594 commented on code in PR #9574: URL: https://github.com/apache/cloudstack/pull/9574#discussion_r1728821450 ## engine/schema/src/main/java/com/cloud/network/as/dao/AutoScaleVmGroupVmMapDaoImpl.java: ## @@ -67,7 +67,7 @@ public int countAvailableVmsByGroup(long vmGroupId)