btzq commented on PR #9574:
URL: https://github.com/apache/cloudstack/pull/9574#issuecomment-2618603260
> @Pearl1594 I am ok with excluding the vms in Error state in the vm count.
should we consider Stopped vms as available in the group ?
>
> my other advice would be
>
> * add
Pearl1594 commented on PR #9574:
URL: https://github.com/apache/cloudstack/pull/9574#issuecomment-2605431214
I added Stopped State imagining a scenario where in say for whatever reason
a host goes down, all VMs belonging to the autoscale group, on that host would
enter stopped state. This w
weizhouapache commented on PR #9574:
URL: https://github.com/apache/cloudstack/pull/9574#issuecomment-2604967576
@Pearl1594
I am ok with excluding the vms in Error state in the vm count.
should we consider Stopped vms as available in the group ?
my other advice would be
- add
Pearl1594 commented on code in PR #9574:
URL: https://github.com/apache/cloudstack/pull/9574#discussion_r1728821450
##
engine/schema/src/main/java/com/cloud/network/as/dao/AutoScaleVmGroupVmMapDaoImpl.java:
##
@@ -67,7 +67,7 @@ public int countAvailableVmsByGroup(long vmGroupId)