GutoVeronezi merged PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cl
GutoVeronezi commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2133664813
Merging as the tests errors are not related to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
DaanHoogland commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2090505983
> @DaanHoogland there seems to be a problem with `test_events_resource.py`.
It's failing in other PRs recently too: [#8981
(comment)](https://github.com/apache/cloudstack/pull/898
winterhazel commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2090294805
@DaanHoogland there seems to be a problem with `test_events_resource.py`.
It's failing in other PRs recently too:
https://github.com/apache/cloudstack/pull/8981#issuecomment-208023
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2083782913
[SF] Trillian test result (tid-10070)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50826 seconds
Marvin logs:
https://github.co
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2082073437
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To r
DaanHoogland commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2082069861
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2080341492
[SF] Trillian test result (tid-10052)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51115 seconds
Marvin logs:
https://github.co
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2079309332
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To r
DaanHoogland commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2079306991
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
winterhazel commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2079286992
@DaanHoogland GHI tests are passing now ;)
Can you run the CI one last time so we can proceed with this PR?
--
This is an automated message from the Apache Git Service.
To
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2077166383
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
winterhazel commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2077007474
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2077008276
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
DaanHoogland closed pull request #8243: Normalize dates in Usage and Quota APIs
URL: https://github.com/apache/cloudstack/pull/8243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
winterhazel commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2057156177
@DaanHoogland most of the GHI tests are failing due to an error with
Codecov, which is also happening in other PRs, such as #8890.
```
[2024-04-13T09:52:32.198Z] ['error']
DaanHoogland commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2055975494
@winterhazel I think the smoke test results are environmental, but all but
the most trivial GHI tests fail. Can you have a look?
--
This is an automated message from the Apache
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2053789798
[SF] Trillian test result (tid-9822)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48900 seconds
Marvin logs:
https://github.com
winterhazel opened a new pull request, #8243:
URL: https://github.com/apache/cloudstack/pull/8243
### Description
Dates are always stored in GMT in the database. However, when using the
Usage and Quota APIs, dates are manipulated according to the configuration
`usage.aggregation.time
DaanHoogland closed pull request #8243: Normalize dates in Usage and Quota APIs
URL: https://github.com/apache/cloudstack/pull/8243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2053583054
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To r
DaanHoogland commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2053582414
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
GutoVeronezi commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2052271599
The Simulator CI / build is passing; however, Codecov is struggling with
something during the report upload; thus the errors in the checks.
@DaanHoogland, can we do a last
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2043732856
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2043636331
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
winterhazel commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2043632913
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
winterhazel commented on code in PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#discussion_r1556424510
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaBalanceCmd.java:
##
@@ -43,10 +43,12 @@ public class QuotaBalanceCmd extends BaseC
GutoVeronezi commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2043303604
> > @winterhazel, you mentioned in the description that this PR also affects
quotaStatement and quotaBalance; however, I am not seeing changes in their
command classes. Could you
GutoVeronezi commented on code in PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#discussion_r1556182305
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaBalanceCmd.java:
##
@@ -43,10 +43,12 @@ public class QuotaBalanceCmd extends Base
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2040148045
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2039970366
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
winterhazel commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2039966109
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
winterhazel commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2039964793
@GutoVeronezi this PR should be ready as it is currently, could you take
another look at it?
I just made a small change in the description of some params as I noticed
that t
winterhazel commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2039940037
> @winterhazel, you mentioned in the description that this PR also affects
quotaStatement and quotaBalance; however, I am not seeing changes in their
command classes. Could you che
GutoVeronezi commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2039723185
@winterhazel dismiss my comments regarding `The response should present the
data in UTC, not in the server timezone`. I checked other APIs, like
`listEvents`, and they return the
GutoVeronezi commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2039545466
> quite some q&a work there @GutoVeronezi ;) would it make sense to split
this in a series of smaller PRs? cc @winterhazel .
As this PR is quite small in terms of concept an
DaanHoogland commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2039121464
quite some q&a work there @GutoVeronezi ;) would it make sense to split this
in a series of smaller PRs? cc @winterhazel .
--
This is an automated message from the Apache Git Se
GutoVeronezi commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2038868041
@winterhazel @DaanHoogland
I did some tests with the proposal; following there are some detailed
descriptions of the tests (hope you guys can find time to read it 😃) and so
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2037420593
[SF] Trillian Build Failed (tid-9705)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2037377633
@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has
been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respo
DaanHoogland commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2037372821
@blueorangutan test alma9 kvm-alma9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2037196523
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
codecov-commenter commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2036949004
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8243?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+com
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2036944042
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
winterhazel commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2036941899
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
GutoVeronezi commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2031091283
@DaanHoogland @winterhazel
While trying to test this one (comparing the results without and with the
patch), I faced an error with the Usage Server on the branch `main`. I crea
GutoVeronezi commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2029615048
@DaanHoogland
I am building it right now to test. Hope I can post my results until the end
of the day.
--
This is an automated message from the Apache Git Service.
To respon
DaanHoogland commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2027245770
@GutoVeronezi did you find time to test this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2019239933
[SF] Trillian test result (tid-9573)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 53169 seconds
Marvin logs:
https://github.com/
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2017685047
@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has
been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respo
DaanHoogland commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2017683031
@blueorangutan test alma9 kvm-alma9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2014285331
[SF] Trillian test result (tid-9546)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 53930 seconds
Marvin logs:
https://github.co
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2014158132
[SF] Trillian test result (tid-9547)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46880 seconds
Marvin logs:
https://github.com
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2014140424
[SF] Trillian test result (tid-9545)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45754 seconds
Marvin logs:
https://github.co
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2012103961
@DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt +
xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been
kicked to run smoke tests
--
This i
DaanHoogland commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2012103067
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-281048
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-163232
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress
DaanHoogland commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-160641
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
github-actions[bot] commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-1998899277
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
github-actions[bot] commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-1976512758
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-1942762776
[SF] Trillian test result (tid-9192)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43243 seconds
Marvin logs:
https://github.com
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-1941081590
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To r
DaanHoogland commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-1941077595
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-1940940175
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-1940756882
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress
DaanHoogland commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-1940753503
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
github-actions[bot] commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-1934110264
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
winterhazel commented on code in PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#discussion_r1480511054
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffListCmd.java:
##
@@ -46,19 +46,19 @@ public class QuotaTariffListCmd extends
DaanHoogland commented on code in PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#discussion_r1480209735
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffListCmd.java:
##
@@ -46,19 +46,19 @@ public class QuotaTariffListCmd extend
GutoVeronezi commented on code in PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#discussion_r1479648472
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffListCmd.java:
##
@@ -46,19 +46,19 @@ public class QuotaTariffListCmd extend
DaanHoogland commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-1908227425
@andrijapanicsb I know you have some experience with this, can you comment
on this change?
--
This is an automated message from the Apache Git Service.
To respond to the messag
winterhazel commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-1906806312
Hey @DaanHoogland, I tried to replicate the scenario you described here,
with a MS in Singapore (MS and `usage.execution.timezone` set to GMT+8) and a
DC in Australia (`usage.aggre
DaanHoogland commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-1816391644
> @DaanHoogland the use of the `computeAdjustedTime` causes a lot of
problems, because the user passes a date parameter to the API, MS converts it
to a time zone that the final us
DaanHoogland commented on code in PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#discussion_r1397274718
##
api/src/main/java/org/apache/cloudstack/api/ApiConstants.java:
##
@@ -1088,6 +1088,14 @@ public String toString() {
}
}
+public static fi
GutoVeronezi commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-1816241978
> I'm not so sure we should abandon `private Date computeAdjustedTime(Date
initialDate, TimeZone targetTZ)`, this will have to be tested in strange
scenarios. I've seen Cloudstack
codecov[bot] commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-1815223730
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8243?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
winterhazel commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-1815213976
Here is the full response of the `listUsageRecords` API after applying the
changes. I was not able to include it in the description because it exceeded
the maximum amount of charac
winterhazel opened a new pull request, #8243:
URL: https://github.com/apache/cloudstack/pull/8243
### Description
Dates are always stored in GMT in the database. However, when using the
Usage and Quota APIs, dates are manipulated according to the configuration
`usage.aggregation.time
79 matches
Mail list logo
