Re: [PR] NSX: add back removed code for NSX [cloudstack]

2024-08-14 Thread via GitHub
nvazquez merged PR #9435: URL: https://github.com/apache/cloudstack/pull/9435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@clouds

Re: [PR] NSX: add back removed code for NSX [cloudstack]

2024-08-14 Thread via GitHub
nvazquez commented on PR #9435: URL: https://github.com/apache/cloudstack/pull/9435#issuecomment-2289150295 Merging based on approvals -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] NSX: add back removed code for NSX [cloudstack]

2024-07-29 Thread via GitHub
blueorangutan commented on PR #9435: URL: https://github.com/apache/cloudstack/pull/9435#issuecomment-2257505585 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] NSX: add back removed code for NSX [cloudstack]

2024-07-29 Thread via GitHub
blueorangutan commented on PR #9435: URL: https://github.com/apache/cloudstack/pull/9435#issuecomment-2257442631 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progr

Re: [PR] NSX: add back removed code for NSX [cloudstack]

2024-07-29 Thread via GitHub
rohityadavcloud commented on PR #9435: URL: https://github.com/apache/cloudstack/pull/9435#issuecomment-2257441516 @nvazquez @Pearl1594 can there be some unit tests or integration to catch this? @blueorangutan package -- This is an automated message from the Apache Git Service. To resp

Re: [PR] NSX: add back removed code for NSX [cloudstack]

2024-07-23 Thread via GitHub
codecov[bot] commented on PR #9435: URL: https://github.com/apache/cloudstack/pull/9435#issuecomment-2244677677 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9435?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] NSX: add back removed code for NSX [cloudstack]

2024-07-23 Thread via GitHub
weizhouapache opened a new pull request, #9435: URL: https://github.com/apache/cloudstack/pull/9435 ### Description The code snippet has been removed in the merge forward of PR #9240 in commit 90fe1d5fdcc2909130b5de6803b57feeff194f54 This PR adds the code back.