Re: [PR] Linstor: fix live migrate on non-hyperconverged setups [cloudstack]

2024-11-07 Thread via GitHub
rp- commented on PR #9832: URL: https://github.com/apache/cloudstack/pull/9832#issuecomment-2462081714 > @rp- this has been merged forward to main, but with conflicts. Can you please check if the merge was successful/done properly? thanks LGTM -- This is an automated message from t

Re: [PR] Linstor: fix live migrate on non-hyperconverged setups [cloudstack]

2024-11-07 Thread via GitHub
DaanHoogland commented on PR #9832: URL: https://github.com/apache/cloudstack/pull/9832#issuecomment-2461883376 @rp- this has been merged forward to main, but with conflicts. Can you please check if the merge was successful/done properly? thanks -- This is an automated message from the Ap

Re: [PR] Linstor: fix live migrate on non-hyperconverged setups [cloudstack]

2024-11-07 Thread via GitHub
rohityadavcloud merged PR #9832: URL: https://github.com/apache/cloudstack/pull/9832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] Linstor: fix live migrate on non-hyperconverged setups [cloudstack]

2024-11-01 Thread via GitHub
blueorangutan commented on PR #9832: URL: https://github.com/apache/cloudstack/pull/9832#issuecomment-2452678652 [SF] Trillian test result (tid-11729) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 44188 seconds Marvin logs: https://github.com/

Re: [PR] Linstor: fix live migrate on non-hyperconverged setups [cloudstack]

2024-11-01 Thread via GitHub
blueorangutan commented on PR #9832: URL: https://github.com/apache/cloudstack/pull/9832#issuecomment-2451604797 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Linstor: fix live migrate on non-hyperconverged setups [cloudstack]

2024-11-01 Thread via GitHub
DaanHoogland commented on PR #9832: URL: https://github.com/apache/cloudstack/pull/9832#issuecomment-2451602365 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Linstor: fix live migrate on non-hyperconverged setups [cloudstack]

2024-11-01 Thread via GitHub
blueorangutan commented on PR #9832: URL: https://github.com/apache/cloudstack/pull/9832#issuecomment-2451583920 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Linstor: fix live migrate on non-hyperconverged setups [cloudstack]

2024-11-01 Thread via GitHub
blueorangutan commented on PR #9832: URL: https://github.com/apache/cloudstack/pull/9832#issuecomment-2451503146 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Linstor: fix live migrate on non-hyperconverged setups [cloudstack]

2024-11-01 Thread via GitHub
DaanHoogland commented on PR #9832: URL: https://github.com/apache/cloudstack/pull/9832#issuecomment-2451500499 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Linstor: fix live migrate on non-hyperconverged setups [cloudstack]

2024-10-29 Thread via GitHub
rp- commented on code in PR #9832: URL: https://github.com/apache/cloudstack/pull/9832#discussion_r1820883814 ## plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java: ## @@ -268,17 +270,33 @@ private void allow2PrimariesIfInUse

Re: [PR] Linstor: fix live migrate on non-hyperconverged setups [cloudstack]

2024-10-29 Thread via GitHub
DaanHoogland commented on code in PR #9832: URL: https://github.com/apache/cloudstack/pull/9832#discussion_r1820458545 ## plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java: ## @@ -268,17 +270,33 @@ private void allow2Primari

Re: [PR] Linstor: fix live migrate on non-hyperconverged setups [cloudstack]

2024-10-29 Thread via GitHub
rp- commented on PR #9832: URL: https://github.com/apache/cloudstack/pull/9832#issuecomment-2443491681 Ok reviewed/discussed this again, we lack the API's currently in Linstor to do this in a perfect way. So this is for now good enough and will also work for all current use cases. -- T

Re: [PR] Linstor: fix live migrate on non-hyperconverged setups [cloudstack]

2024-10-23 Thread via GitHub
blueorangutan commented on PR #9832: URL: https://github.com/apache/cloudstack/pull/9832#issuecomment-2432034235 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Linstor: fix live migrate on non-hyperconverged setups [cloudstack]

2024-10-23 Thread via GitHub
sureshanaparti commented on PR #9832: URL: https://github.com/apache/cloudstack/pull/9832#issuecomment-2431877398 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Linstor: fix live migrate on non-hyperconverged setups [cloudstack]

2024-10-23 Thread via GitHub
rp- commented on PR #9832: URL: https://github.com/apache/cloudstack/pull/9832#issuecomment-2431913016 sorry have to rework it a bit, to be more fine grained in the non-hyperconverged case -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Linstor: fix live migrate on non-hyperconverged setups [cloudstack]

2024-10-23 Thread via GitHub
blueorangutan commented on PR #9832: URL: https://github.com/apache/cloudstack/pull/9832#issuecomment-2431880670 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] Linstor: fix live migrate on non-hyperconverged setups [cloudstack]

2024-10-21 Thread via GitHub
codecov[bot] commented on PR #9832: URL: https://github.com/apache/cloudstack/pull/9832#issuecomment-2426574392 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9832?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] Linstor: fix live migrate on non-hyperconverged setups [cloudstack]

2024-10-21 Thread via GitHub
rp- opened a new pull request, #9832: URL: https://github.com/apache/cloudstack/pull/9832 ### Description In non-hyperconverged setups, diskless nodes don't have a connection to each other, so setting properties there had no effect. Now it is checked if a connection exists, betwee