Re: [PR] Grant access to 2FA APIs for default read-only and support roles [cloudstack]

2025-01-30 Thread via GitHub
DaanHoogland commented on PR #10273: URL: https://github.com/apache/cloudstack/pull/10273#issuecomment-2624960332 > @DaanHoogland, should I open another PR targeting the `4.20` branch and adding the SQL queries to the `schema-42000to42010.sql` file? those are two half statements @bern

Re: [PR] Grant access to 2FA APIs for default read-only and support roles [cloudstack]

2025-01-30 Thread via GitHub
bernardodemarco commented on PR #10273: URL: https://github.com/apache/cloudstack/pull/10273#issuecomment-2624858586 @DaanHoogland, should I open another PR targeting the `4.20` branch and adding the SQL queries to the `schema-42000to42010.sql` file? -- This is an automated message from

Re: [PR] Grant access to 2FA APIs for default read-only and support roles [cloudstack]

2025-01-30 Thread via GitHub
DaanHoogland merged PR #10273: URL: https://github.com/apache/cloudstack/pull/10273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [PR] Grant access to 2FA APIs for default read-only and support roles [cloudstack]

2025-01-30 Thread via GitHub
blueorangutan commented on PR #10273: URL: https://github.com/apache/cloudstack/pull/10273#issuecomment-2623849740 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Grant access to 2FA APIs for default read-only and support roles [cloudstack]

2025-01-29 Thread via GitHub
blueorangutan commented on PR #10273: URL: https://github.com/apache/cloudstack/pull/10273#issuecomment-2623747523 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Grant access to 2FA APIs for default read-only and support roles [cloudstack]

2025-01-29 Thread via GitHub
harikrishna-patnala commented on PR #10273: URL: https://github.com/apache/cloudstack/pull/10273#issuecomment-2623745868 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Grant access to 2FA APIs for default read-only and support roles [cloudstack]

2025-01-29 Thread via GitHub
bernardodemarco commented on PR #10273: URL: https://github.com/apache/cloudstack/pull/10273#issuecomment-2622348322 > 4.19 is fine but a bit late and as this needs adjustment of the sql file , you could choose to go for 4.20. On the other hand the current implementation is suitable to be i

Re: [PR] Grant access to 2FA APIs for default read-only and support roles [cloudstack]

2025-01-28 Thread via GitHub
blueorangutan commented on PR #10273: URL: https://github.com/apache/cloudstack/pull/10273#issuecomment-2620257695 @bernardodemarco a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make pro

Re: [PR] Grant access to 2FA APIs for default read-only and support roles [cloudstack]

2025-01-28 Thread via GitHub
bernardodemarco commented on PR #10273: URL: https://github.com/apache/cloudstack/pull/10273#issuecomment-2620256598 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Grant access to 2FA APIs for default read-only and support roles [cloudstack]

2025-01-27 Thread via GitHub
bernardodemarco commented on PR #10273: URL: https://github.com/apache/cloudstack/pull/10273#issuecomment-2615512031 @harikrishna-patnala, thanks for your review. I believe that it would be better to create the SQL procedure to abstract this operation. I'll be working on it and, in the mean

Re: [PR] Grant access to 2FA APIs for default read-only and support roles [cloudstack]

2025-01-25 Thread via GitHub
blueorangutan commented on PR #10273: URL: https://github.com/apache/cloudstack/pull/10273#issuecomment-2614099246 @bernardodemarco a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make pro

Re: [PR] Grant access to 2FA APIs for default read-only and support roles [cloudstack]

2025-01-25 Thread via GitHub
blueorangutan commented on PR #10273: URL: https://github.com/apache/cloudstack/pull/10273#issuecomment-2614115198 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Grant access to 2FA APIs for default read-only and support roles [cloudstack]

2025-01-25 Thread via GitHub
bernardodemarco commented on PR #10273: URL: https://github.com/apache/cloudstack/pull/10273#issuecomment-2614099066 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Grant access to 2FA APIs for default read-only and support roles [cloudstack]

2025-01-25 Thread via GitHub
bernardodemarco commented on PR #10273: URL: https://github.com/apache/cloudstack/pull/10273#issuecomment-2614098910 Guys, should the changes in this PR also be applied to versions 4.19 and 4.20? If so, I think it would be necessary to open a new PR targeting each version branch, right? -

Re: [PR] Grant access to 2FA APIs for default read-only and support roles [cloudstack]

2025-01-25 Thread via GitHub
codecov[bot] commented on PR #10273: URL: https://github.com/apache/cloudstack/pull/10273#issuecomment-2614098948 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10273?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[PR] Grant access to 2FA APIs for default read-only and support roles [cloudstack]

2025-01-25 Thread via GitHub
bernardodemarco opened a new pull request, #10273: URL: https://github.com/apache/cloudstack/pull/10273 ### Description Accounts created with the `Read-Only User - Default` and `Support User - Default` roles do not have access to `setupUserTwoFactorAuthentication`, `validateUserTwoFa