Re: [PR] Fix link to removed volumes being shown in info card [cloudstack]

2024-05-28 Thread via GitHub
winterhazel commented on PR #8833: URL: https://github.com/apache/cloudstack/pull/8833#issuecomment-2135773444 Hey @lucas-a-martins @DaanHoogland, sorry for the delay. Looking back at this PR, I think it would be better to implement the link validation in both pages by including the v

Re: [PR] Fix link to removed volumes being shown in info card [cloudstack]

2024-04-24 Thread via GitHub
winterhazel commented on PR #8833: URL: https://github.com/apache/cloudstack/pull/8833#issuecomment-2075234849 Thanks for testing @lucas-a-martins. At first, I think the issue regarding invalid links in the list view should be tackled in another PR, but I'll investigate how it could be impl

Re: [PR] Fix link to removed volumes being shown in info card [cloudstack]

2024-04-23 Thread via GitHub
DaanHoogland commented on PR #8833: URL: https://github.com/apache/cloudstack/pull/8833#issuecomment-2074182760 @winterhazel , I marked this for 4.20 now as it is targeted for main. Do you want this in 4.19? -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Fix link to removed volumes being shown in info card [cloudstack]

2024-03-29 Thread via GitHub
DaanHoogland commented on PR #8833: URL: https://github.com/apache/cloudstack/pull/8833#issuecomment-2027311764 qa does not seem to be responsive, not tested! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Fix link to removed volumes being shown in info card [cloudstack]

2024-03-27 Thread via GitHub
blueorangutan commented on PR #8833: URL: https://github.com/apache/cloudstack/pull/8833#issuecomment-2022320997 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8833 (QA-JID-309) -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Fix link to removed volumes being shown in info card [cloudstack]

2024-03-27 Thread via GitHub
sureshanaparti commented on PR #8833: URL: https://github.com/apache/cloudstack/pull/8833#issuecomment-2022291782 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Fix link to removed volumes being shown in info card [cloudstack]

2024-03-27 Thread via GitHub
blueorangutan commented on PR #8833: URL: https://github.com/apache/cloudstack/pull/8833#issuecomment-2022293464 @sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] Fix link to removed volumes being shown in info card [cloudstack]

2024-03-26 Thread via GitHub
codecov[bot] commented on PR #8833: URL: https://github.com/apache/cloudstack/pull/8833#issuecomment-2020236986 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8833?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] Fix link to removed volumes being shown in info card [cloudstack]

2024-03-26 Thread via GitHub
winterhazel opened a new pull request, #8833: URL: https://github.com/apache/cloudstack/pull/8833 ### Description The snapshot details page shows a link to the snapshotted volume. However, if the volume has been removed, it is not possible to access its page, resulting in a 404 when