Re: [PR] Fix filter and pagination on API findStoragePoolsForMigration [cloudstack]

2024-02-16 Thread via GitHub
DaanHoogland merged PR #8306: URL: https://github.com/apache/cloudstack/pull/8306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] Fix filter and pagination on API findStoragePoolsForMigration [cloudstack]

2024-02-15 Thread via GitHub
GaOrtiga commented on code in PR #8306: URL: https://github.com/apache/cloudstack/pull/8306#discussion_r1491278333 ## engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java: ## @@ -443,9 +451,14 @@ public List findDisabledPoolsByScope

Re: [PR] Fix filter and pagination on API findStoragePoolsForMigration [cloudstack]

2024-02-15 Thread via GitHub
DaanHoogland commented on code in PR #8306: URL: https://github.com/apache/cloudstack/pull/8306#discussion_r1490711474 ## engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java: ## @@ -443,9 +451,14 @@ public List findDisabledPoolsByS

Re: [PR] Fix filter and pagination on API findStoragePoolsForMigration [cloudstack]

2024-02-14 Thread via GitHub
GutoVeronezi commented on code in PR #8306: URL: https://github.com/apache/cloudstack/pull/8306#discussion_r1490117473 ## engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java: ## @@ -443,9 +451,14 @@ public List findDisabledPoolsByS

Re: [PR] Fix filter and pagination on API findStoragePoolsForMigration [cloudstack]

2024-02-12 Thread via GitHub
DaanHoogland commented on PR #8306: URL: https://github.com/apache/cloudstack/pull/8306#issuecomment-1938423421 the usual suspects in the smoke test results: ``` Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:

Re: [PR] Fix filter and pagination on API findStoragePoolsForMigration [cloudstack]

2024-02-09 Thread via GitHub
blueorangutan commented on PR #8306: URL: https://github.com/apache/cloudstack/pull/8306#issuecomment-1936186374 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] Fix filter and pagination on API findStoragePoolsForMigration [cloudstack]

2024-02-09 Thread via GitHub
DaanHoogland commented on PR #8306: URL: https://github.com/apache/cloudstack/pull/8306#issuecomment-1936183325 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Fix filter and pagination on API findStoragePoolsForMigration [cloudstack]

2024-02-08 Thread via GitHub
blueorangutan commented on PR #8306: URL: https://github.com/apache/cloudstack/pull/8306#issuecomment-1934721637 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progr

Re: [PR] Fix filter and pagination on API findStoragePoolsForMigration [cloudstack]

2024-02-08 Thread via GitHub
rohityadavcloud commented on PR #8306: URL: https://github.com/apache/cloudstack/pull/8306#issuecomment-1934720322 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Fix filter and pagination on API findStoragePoolsForMigration [cloudstack]

2023-12-05 Thread via GitHub
codecov[bot] commented on PR #8306: URL: https://github.com/apache/cloudstack/pull/8306#issuecomment-1841085165 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8306?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] Fix filter and pagination on API findStoragePoolsForMigration [cloudstack]

2023-12-05 Thread via GitHub
GaOrtiga commented on PR #8306: URL: https://github.com/apache/cloudstack/pull/8306#issuecomment-1840793982 > @GaOrtiga should there be some UI change for this as well? @DaanHoogland It will not be necessary; the UI issues were a result of pagination problems within the API, which hav

Re: [PR] Fix filter and pagination on API findStoragePoolsForMigration [cloudstack]

2023-12-05 Thread via GitHub
DaanHoogland commented on PR #8306: URL: https://github.com/apache/cloudstack/pull/8306#issuecomment-1840729131 @GaOrtiga should there be some UI change for this as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use