Re: [PR] Fix deletion of backup schedules [cloudstack]

2025-07-23 Thread via GitHub
sureshanaparti commented on code in PR #11222: URL: https://github.com/apache/cloudstack/pull/11222#discussion_r2224754541 ## api/src/main/java/org/apache/cloudstack/api/response/BackupScheduleResponse.java: ## @@ -28,6 +28,9 @@ @EntityReference(value = BackupSchedule.class)

Re: [PR] Fix deletion of backup schedules [cloudstack]

2025-07-23 Thread via GitHub
DaanHoogland merged PR #11222: URL: https://github.com/apache/cloudstack/pull/11222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [PR] Fix deletion of backup schedules [cloudstack]

2025-07-22 Thread via GitHub
blueorangutan commented on PR #11222: URL: https://github.com/apache/cloudstack/pull/11222#issuecomment-3105001050 [SF] Trillian test result (tid-13836) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 56165 seconds Marvin logs: https://github.co

Re: [PR] Fix deletion of backup schedules [cloudstack]

2025-07-22 Thread via GitHub
sureshanaparti commented on code in PR #11222: URL: https://github.com/apache/cloudstack/pull/11222#discussion_r437262 ## api/src/main/java/org/apache/cloudstack/api/response/BackupScheduleResponse.java: ## @@ -28,6 +28,9 @@ @EntityReference(value = BackupSchedule.class)

Re: [PR] Fix deletion of backup schedules [cloudstack]

2025-07-21 Thread via GitHub
blueorangutan commented on PR #11222: URL: https://github.com/apache/cloudstack/pull/11222#issuecomment-3101194188 @sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respo

Re: [PR] Fix deletion of backup schedules [cloudstack]

2025-07-21 Thread via GitHub
sureshanaparti commented on PR #11222: URL: https://github.com/apache/cloudstack/pull/11222#issuecomment-3101190694 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Fix deletion of backup schedules [cloudstack]

2025-07-21 Thread via GitHub
blueorangutan commented on PR #11222: URL: https://github.com/apache/cloudstack/pull/11222#issuecomment-3101174539 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Fix deletion of backup schedules [cloudstack]

2025-07-21 Thread via GitHub
blueorangutan commented on PR #11222: URL: https://github.com/apache/cloudstack/pull/11222#issuecomment-3100857896 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make prog

Re: [PR] Fix deletion of backup schedules [cloudstack]

2025-07-21 Thread via GitHub
sureshanaparti commented on PR #11222: URL: https://github.com/apache/cloudstack/pull/11222#issuecomment-3100854332 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Fix deletion of backup schedules [cloudstack]

2025-07-21 Thread via GitHub
winterhazel commented on PR #11222: URL: https://github.com/apache/cloudstack/pull/11222#issuecomment-3100621586 @sureshanaparti can we run the CI here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Fix deletion of backup schedules [cloudstack]

2025-07-17 Thread via GitHub
bernardodemarco commented on PR #11222: URL: https://github.com/apache/cloudstack/pull/11222#issuecomment-3084769900 @abh1sar thanks for your review and @winterhazel thanks for testing! > Some remarks: > - I noticed that when a user deletes the last backup schedule of a VM via the

Re: [PR] Fix deletion of backup schedules [cloudstack]

2025-07-16 Thread via GitHub
blueorangutan commented on PR #11222: URL: https://github.com/apache/cloudstack/pull/11222#issuecomment-3079572052 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Fix deletion of backup schedules [cloudstack]

2025-07-16 Thread via GitHub
blueorangutan commented on PR #11222: URL: https://github.com/apache/cloudstack/pull/11222#issuecomment-3079219929 @bernardodemarco a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make pro

Re: [PR] Fix deletion of backup schedules [cloudstack]

2025-07-16 Thread via GitHub
bernardodemarco commented on PR #11222: URL: https://github.com/apache/cloudstack/pull/11222#issuecomment-3079214394 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Fix deletion of backup schedules [cloudstack]

2025-07-16 Thread via GitHub
bernardodemarco commented on code in PR #11222: URL: https://github.com/apache/cloudstack/pull/11222#discussion_r2210810184 ## server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java: ## @@ -515,24 +516,44 @@ public List listBackupSchedule(final Long vmId) {

Re: [PR] Fix deletion of backup schedules [cloudstack]

2025-07-16 Thread via GitHub
DaanHoogland commented on code in PR #11222: URL: https://github.com/apache/cloudstack/pull/11222#discussion_r2210649674 ## server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java: ## @@ -515,24 +516,44 @@ public List listBackupSchedule(final Long vmId) {

Re: [PR] Fix deletion of backup schedules [cloudstack]

2025-07-16 Thread via GitHub
codecov[bot] commented on PR #11222: URL: https://github.com/apache/cloudstack/pull/11222#issuecomment-3078901803 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11222?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[PR] Fix deletion of backup schedules [cloudstack]

2025-07-16 Thread via GitHub
bernardodemarco opened a new pull request, #11222: URL: https://github.com/apache/cloudstack/pull/11222 ### Description PR #9666 introduced changes to fix issues with the deletion of backup schedules. Prior to that PR, the `deleteBackupSchedule` API accepted only one parameter (`virt