Re: [PR] Fix: copy to clipboard console url for safari [cloudstack]

2024-07-12 Thread via GitHub
vishesh92 commented on PR #9378: URL: https://github.com/apache/cloudstack/pull/9378#issuecomment-2225289779 Covered in https://github.com/apache/cloudstack/pull/9381/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Fix: copy to clipboard console url for safari [cloudstack]

2024-07-12 Thread via GitHub
vishesh92 closed pull request #9378: Fix: copy to clipboard console url for safari URL: https://github.com/apache/cloudstack/pull/9378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Fix: copy to clipboard console url for safari [cloudstack]

2024-07-12 Thread via GitHub
rohityadavcloud commented on PR #9378: URL: https://github.com/apache/cloudstack/pull/9378#issuecomment-2225198823 sorry doesn't work @vishesh92 cc @DaanHoogland -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Fix: copy to clipboard console url for safari [cloudstack]

2024-07-12 Thread via GitHub
rohityadavcloud commented on PR #9378: URL: https://github.com/apache/cloudstack/pull/9378#issuecomment-2225195015 LGTM, tested OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Fix: copy to clipboard console url for safari [cloudstack]

2024-07-12 Thread via GitHub
blueorangutan commented on PR #9378: URL: https://github.com/apache/cloudstack/pull/9378#issuecomment-2225192991 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9378 (QA-JID-401) -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Fix: copy to clipboard console url for safari [cloudstack]

2024-07-12 Thread via GitHub
DaanHoogland commented on PR #9378: URL: https://github.com/apache/cloudstack/pull/9378#issuecomment-2225186574 I suppose you tested on Safari @rohityadavcloud ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Fix: copy to clipboard console url for safari [cloudstack]

2024-07-12 Thread via GitHub
blueorangutan commented on PR #9378: URL: https://github.com/apache/cloudstack/pull/9378#issuecomment-2225171925 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9378 (QA-JID-400) -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Fix: copy to clipboard console url for safari [cloudstack]

2024-07-12 Thread via GitHub
blueorangutan commented on PR #9378: URL: https://github.com/apache/cloudstack/pull/9378#issuecomment-2225164405 @vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Fix: copy to clipboard console url for safari [cloudstack]

2024-07-12 Thread via GitHub
vishesh92 commented on PR #9378: URL: https://github.com/apache/cloudstack/pull/9378#issuecomment-2225162210 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Fix: copy to clipboard console url for safari [cloudstack]

2024-07-12 Thread via GitHub
codecov[bot] commented on PR #9378: URL: https://github.com/apache/cloudstack/pull/9378#issuecomment-2225157742 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9378?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments