rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1633089559
##
api/src/main/java/org/apache/cloudstack/query/QueryService.java:
##
@@ -125,6 +125,10 @@ public interface QueryService {
static final ConfigKey Share
rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1627648506
##
api/src/main/java/org/apache/cloudstack/query/QueryService.java:
##
@@ -125,6 +125,10 @@ public interface QueryService {
static final ConfigKey Share
rohityadavcloud merged PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1627646972
##
api/src/main/java/org/apache/cloudstack/query/QueryService.java:
##
@@ -125,6 +125,10 @@ public interface QueryService {
static final ConfigKey Share
rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1627643622
##
api/src/main/java/org/apache/cloudstack/query/QueryService.java:
##
@@ -125,6 +125,10 @@ public interface QueryService {
static final ConfigKey Share
rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1627643622
##
api/src/main/java/org/apache/cloudstack/query/QueryService.java:
##
@@ -125,6 +125,10 @@ public interface QueryService {
static final ConfigKey Share
JoaoJandre commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1613880989
##
api/src/main/java/org/apache/cloudstack/query/QueryService.java:
##
@@ -125,6 +125,10 @@ public interface QueryService {
static final ConfigKey SharePubli
weizhouapache commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1611124410
##
api/src/main/java/org/apache/cloudstack/query/QueryService.java:
##
@@ -125,6 +125,10 @@ public interface QueryService {
static final ConfigKey SharePu
blueorangutan commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2126304002
[SF] Trillian test result (tid-10254)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43718 seconds
Marvin logs:
https://github.co
rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1609919869
##
api/src/main/java/org/apache/cloudstack/query/QueryService.java:
##
@@ -125,6 +125,10 @@ public interface QueryService {
static final ConfigKey Share
rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1609919869
##
api/src/main/java/org/apache/cloudstack/query/QueryService.java:
##
@@ -125,6 +125,10 @@ public interface QueryService {
static final ConfigKey Share
blueorangutan commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2124637263
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To r
DaanHoogland commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2124634140
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
blueorangutan commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2124344026
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
DaanHoogland commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2124184248
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2124184788
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress
DaanHoogland commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2124183914
ping @sureshanaparti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2118993559
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 9631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2118981715
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress
DaanHoogland commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2118981531
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
DaanHoogland commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2118981510
@sureshanaparti ok by you like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
JoaoJandre commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1595405926
##
api/src/main/java/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java:
##
@@ -239,22 +240,32 @@ public Long getAutoScaleVmGroupId() {
return aut
rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1594262602
##
api/src/main/java/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java:
##
@@ -98,7 +99,7 @@ public class ListVMsCmd extends
BaseListRetrieveOnlyRes
rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1594260186
##
ui/src/config/section/compute.js:
##
@@ -28,7 +28,8 @@ export default {
title: 'label.instances',
icon: 'cloud-server-outlined',
docH
rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1594259073
##
api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java:
##
@@ -269,6 +270,10 @@ public class UserVmResponse extends
BaseResponseWithTag
rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1594256781
##
plugins/metrics/src/main/java/org/apache/cloudstack/metrics/MetricsServiceImpl.java:
##
@@ -617,7 +617,6 @@ public List
listVmMetrics(List vmResponses) {
rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1594255135
##
api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java:
##
@@ -269,6 +270,10 @@ public class UserVmResponse extends
BaseResponseWithTag
rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1594253988
##
api/src/main/java/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java:
##
@@ -239,22 +240,32 @@ public Long getAutoScaleVmGroupId() {
retur
rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1594251304
##
plugins/metrics/src/main/java/org/apache/cloudstack/api/ListVMsMetricsCmd.java:
##
@@ -42,20 +44,24 @@
* although most of it is not suitable/useful
rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1594250805
##
api/src/main/java/org/apache/cloudstack/query/QueryService.java:
##
@@ -125,6 +125,10 @@ public interface QueryService {
static final ConfigKey Share
rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1594248650
##
api/src/main/java/org/apache/cloudstack/query/QueryService.java:
##
@@ -125,6 +125,10 @@ public interface QueryService {
static final ConfigKey Share
rohityadavcloud commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2100866289
I like the idea of splitting which API is called for metrics vs non-metrics
list view (I might or others should steal the pattern for all metrics API usage
across the UI). I'm
blueorangutan commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2097800705
[SF] Trillian test result (tid-10170)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 49325 seconds
Marvin logs:
https://github.co
weizhouapache commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2096678220
> @rohityadavcloud , @weizhouapache I added a configuration to control the
behavior of the `listVirtualMachines` API and updated the description. Now the
default behavior is main
blueorangutan commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2096677911
@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To re
weizhouapache commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2096677088
@blueorangutan test rocky8 kvm-rocky8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
JoaoJandre commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2096632612
@rohityadavcloud , @weizhouapache I added a configuration to control the
behavior of the `listVirtualMachines` API and updated the description. Now the
default behavior is maintain
blueorangutan commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2096631514
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2096515098
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
JoaoJandre commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2096513632
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
codecov-commenter commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-2093203184
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8782?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+com
JoaoJandre commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-1997435998
> @JoaoJandre I suggest to check/fix the API calls from UI to list vms or vm
metrics.
>
> It is not good to change the default behavior if it is not a bug, IMHO.
@weizh
rohityadavcloud commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-1997341885
> For both the listVirtualMachines and listVirtualMachineMetrics APIs, by
default, ACS queries all VM details (the details parameter is default all) and
consequently queries th
sureshanaparti commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1524558887
##
api/src/main/java/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java:
##
@@ -98,7 +99,8 @@ public class ListVMsCmd extends
BaseListRetrieveOnlyReso
weizhouapache commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-1995297443
@JoaoJandre
I suggest to check/fix the API calls from UI to list vms or vm metrics.
It is not good to change the default behavior if it is not a bug, IMHO.
--
codecov[bot] commented on PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#issuecomment-1995275633
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8782?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
JoaoJandre opened a new pull request, #8782:
URL: https://github.com/apache/cloudstack/pull/8782
### Description
For both the `listVirtualMachines` and `listVirtualMachineMetrics` APIs, by
default, ACS queries all VM details (the `details` parameter is default `all`)
and consequently
47 matches
Mail list logo
