JoaoJandre commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-2291813291
Merging based on approvals, CI result and manual tests
(https://github.com/apache/cloudstack/pull/8556#issuecomment-1912653892)
--
This is an automated message from the Apache Git
JoaoJandre merged PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@clou
blueorangutan commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-2290170108
[SF] Trillian test result (tid-11074)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 50926 seconds
Marvin logs:
https://github.com/
blueorangutan commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-2288343619
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been
kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond t
DaanHoogland commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-2288339920
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
blueorangutan commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-2288297705
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
blueorangutan commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-2287046802
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
blueorangutan commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-2286984952
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
JoaoJandre commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-2286983432
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
blueorangutan commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-2248325245
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-2247791747
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
JoaoJandre commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-2247788777
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
blueorangutan commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-2060467060
[SF] Trillian test result (tid-9858)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 53146 seconds
Marvin logs:
https://github.com
blueorangutan commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-2059328054
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To r
DaanHoogland commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-2059324075
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
JoaoJandre commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-2059296154
@DaanHoogland @sureshanaparti @rohityadavcloud @shwstppr could we run the CI
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
blueorangutan commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-2059179175
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-2059028098
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
JoaoJandre commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-2059023957
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
blueorangutan commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1948533412
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To r
DaanHoogland commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1948532722
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
blueorangutan commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1948232175
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1948105665
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress
DaanHoogland commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1948104438
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
GaOrtiga commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1946485515
@rohityadavcloud
> * Would this also deletion of systemvmtemplate current in use?
> * If that's the case, can we add a check so it won't allow deleting
systemvmtemplate in use
weizhouapache commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1916557198
> I think both sides of the discussion have valid points and this will have
to prove itself in production. I am ok with the API only implementation.
thanks @DaanHoo
DaanHoogland commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1916452887
I think both sides of the discussion have valid points and this will have to
prove itself in production. I am ok with the API only implementation.
--
This is an automated messag
blueorangutan commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1915246559
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
blueorangutan commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1915065429
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progres
weizhouapache commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1915064260
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
GaOrtiga commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1914837171
> ok @GaOrtiga so admins have to use api or cmk, right ?
Yes.
> this does not help admins a lot.
Since some security concerns have been brought up, I felt that limi
weizhouapache commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1914572378
> > @GaOrtiga
> > will you support it on UI ?
>
> @weizhouapache No I will not. In my opinion, adding it to the UI would
risk some of the security concerns that you poin
weizhouapache commented on code in PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#discussion_r1469502874
##
api/src/main/java/org/apache/cloudstack/api/command/user/template/DeleteTemplateCmd.java:
##
@@ -55,6 +55,9 @@ public class DeleteTemplateCmd extends BaseAs
GaOrtiga commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1914564293
>@GaOrtiga
will you support it on UI ?
@weizhouapache No I will not. In my opinion, adding it to the UI would risk
some of the security concerns that you pointed out earlier
weizhouapache commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1912653892
@GaOrtiga
will you support it on UI ?
API is tested ok
```
(localcloud) 🐱 > delete template id=d0b0a4db-1125-4a99-8cca-cf7934bbc19b
{
"account": "admin
weizhouapache commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1910794735
>
> I could add a new parameter, maybe `system` to make it very clear on
what's the intent of the flag. This would make it so that these templates can
be deleted without
weizhouapache commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1910754696
> @weizhouapache
>
> > Can you tell me how frequent you deleted the SYSTEM template?
>
> Even if it's not something that is done frequently, it being purposely
less
GaOrtiga commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1910737992
@weizhouapache
> Can you tell me how frequent you deleted the SYSTEM template?
Even if it's not something that is done frequently, it being purposely less
intuitive impacts
weizhouapache commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1910671560
> > > > @GaOrtiga @DaanHoogland sorry this PR is not needed in my opinion
> > >
> > >
> > > Having a workaround should not be a reason to restrict an operation.
If the
GaOrtiga commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1910027444
> > > @GaOrtiga @DaanHoogland sorry this PR is not needed in my opinion
> >
> >
> > Having a workaround should not be a reason to restrict an operation. If
the operator does
DaanHoogland commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1909764351
What do you think of @weizhouapache 's last sugestion @GaOrtiga ? would this
satisfy both your requirements?
--
This is an automated message from the Apache Git Service.
To resp
weizhouapache commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1908566764
> > @GaOrtiga @DaanHoogland sorry this PR is not needed in my opinion
>
> Having a workaround should not be a reason to restrict an operation. If
the operator does not know
weizhouapache commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1908559652
> The use case would be any operator that wants to delete `SYSTEM` templates
and does not know about the workaround, since it's not really something
self-explanatory.
@GaO
GaOrtiga commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1908522137
> > @GaOrtiga as a user wants this convenience. Even when I agree that it is
not vital, that would be enough for it to be needed.
> >
> > * Is there any more pressing objection
GaOrtiga commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1908508050
> @GaOrtiga @DaanHoogland sorry this PR is not needed in my opinion
Having a workaround should not be a reason to restrict an operation. If the
operator does not know that you c
weizhouapache commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1908414021
@DaanHoogland @GaOrtiga
let me explain a bit more
users might delete the unused SYSTEM template one or twice every year by
average. It takes just few minutes.
Howeve
weizhouapache commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1908378077
> @GaOrtiga as a user wants this convenience. Even when I agree that it is
not vital, that would be enough for it to be needed.
>
> * Is there any more pressing objection @
DaanHoogland commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1908351734
@GaOrtiga as a user wants this convenience. Even when I agree that it is not
vital, that would be enough for it to be needed.
- Is there any more pressing objection @weizhouapac
weizhouapache commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1908317390
@GaOrtiga @DaanHoogland
sorry this PR is not needed in my opinion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
GaOrtiga commented on code in PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#discussion_r1465051345
##
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##
@@ -748,9 +748,6 @@ void checkAndRemoveTemplateDetails(VMTemplateVO template) {
p
GaOrtiga commented on code in PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#discussion_r1465047023
##
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##
@@ -748,9 +748,6 @@ void checkAndRemoveTemplateDetails(VMTemplateVO template) {
p
DaanHoogland commented on code in PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#discussion_r1465022426
##
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##
@@ -748,9 +748,6 @@ void checkAndRemoveTemplateDetails(VMTemplateVO template) {
GaOrtiga commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1908228049
> @GaOrtiga If you update the template to USER, then you will be able to
remove it. this will prevent some human mistakes
@weizhouapache I understand that there is a way to circ
weizhouapache commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1907578733
> @GaOrtiga If you update the template to USER, then you will be able to
remove it. this will prevent some human mistakes
@GaOrtiga @DaanHoogland
do you agree and close
codecov[bot] commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1907439331
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8556?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
weizhouapache commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1906168608
@GaOrtiga
If you update the template to USER, then you will be able to remove it.
this will prevent some human mistakes
--
This is an automated message from the Apache Gi
GaOrtiga opened a new pull request, #8556:
URL: https://github.com/apache/cloudstack/pull/8556
### Description
Currently, ACS does not allow the deletion of system VM templates. However,
it might be of interest to the operator to delete templates from older versions
that are no longe
57 matches
Mail list logo
