Re: [PR] Allow deleteion of external managed cks nodes [cloudstack]

2024-06-14 Thread via GitHub
github-actions[bot] commented on PR #9183: URL: https://github.com/apache/cloudstack/pull/9183#issuecomment-2167432458 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] Allow deleteion of external managed cks nodes [cloudstack]

2024-06-08 Thread via GitHub
vishesh92 commented on PR #9183: URL: https://github.com/apache/cloudstack/pull/9183#issuecomment-2155872142 > What happens to the cluster-vm mapping? Do we need to remove it? I don't think we need to remove it. Worst case an entry is left over in the table. -- This is an automated

Re: [PR] Allow deleteion of external managed cks nodes [cloudstack]

2024-06-06 Thread via GitHub
blueorangutan commented on PR #9183: URL: https://github.com/apache/cloudstack/pull/9183#issuecomment-2152063580 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9808 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Allow deleteion of external managed cks nodes [cloudstack]

2024-06-06 Thread via GitHub
shwstppr commented on code in PR #9183: URL: https://github.com/apache/cloudstack/pull/9183#discussion_r1629283890 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterHelperImpl.java: ## @@ -58,6 +58,9 @@ public void checkVmCanB

Re: [PR] Allow deleteion of external managed cks nodes [cloudstack]

2024-06-06 Thread via GitHub
blueorangutan commented on PR #9183: URL: https://github.com/apache/cloudstack/pull/9183#issuecomment-2151903495 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Allow deleteion of external managed cks nodes [cloudstack]

2024-06-06 Thread via GitHub
vishesh92 commented on PR #9183: URL: https://github.com/apache/cloudstack/pull/9183#issuecomment-2151902548 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Allow deleteion of external managed cks nodes [cloudstack]

2024-06-06 Thread via GitHub
codecov[bot] commented on PR #9183: URL: https://github.com/apache/cloudstack/pull/9183#issuecomment-2151881552 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9183?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] Allow deleteion of external managed cks nodes [cloudstack]

2024-06-06 Thread via GitHub
vishesh92 opened a new pull request, #9183: URL: https://github.com/apache/cloudstack/pull/9183 ### Description This PR allows deletion of CKS node if the CKS cluster is Externally managed. ### Types of changes - [ ] Bre