Re: [PR] Allow autoscale group and name override [cloudstack]

2023-12-07 Thread via GitHub
boring-cyborg[bot] commented on PR #8324: URL: https://github.com/apache/cloudstack/pull/8324#issuecomment-1846584381 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Allow autoscale group and name override [cloudstack]

2023-12-07 Thread via GitHub
shwstppr merged PR #8324: URL: https://github.com/apache/cloudstack/pull/8324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@clouds

Re: [PR] Allow autoscale group and name override [cloudstack]

2023-12-07 Thread via GitHub
blueorangutan commented on PR #8324: URL: https://github.com/apache/cloudstack/pull/8324#issuecomment-1846415514 [SF] Trillian test result (tid-8505) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49697 seconds Marvin logs: https://github.com

Re: [PR] Allow autoscale group and name override [cloudstack]

2023-12-07 Thread via GitHub
blueorangutan commented on PR #8324: URL: https://github.com/apache/cloudstack/pull/8324#issuecomment-1845157148 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] Allow autoscale group and name override [cloudstack]

2023-12-07 Thread via GitHub
DaanHoogland commented on PR #8324: URL: https://github.com/apache/cloudstack/pull/8324#issuecomment-1845154702 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Allow autoscale group and name override [cloudstack]

2023-12-07 Thread via GitHub
blueorangutan commented on PR #8324: URL: https://github.com/apache/cloudstack/pull/8324#issuecomment-1845023424 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7966 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Allow autoscale group and name override [cloudstack]

2023-12-07 Thread via GitHub
blueorangutan commented on PR #8324: URL: https://github.com/apache/cloudstack/pull/8324#issuecomment-1844921705 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Allow autoscale group and name override [cloudstack]

2023-12-07 Thread via GitHub
shwstppr commented on PR #8324: URL: https://github.com/apache/cloudstack/pull/8324#issuecomment-1844920095 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Allow autoscale group and name override [cloudstack]

2023-12-07 Thread via GitHub
weizhouapache commented on PR #8324: URL: https://github.com/apache/cloudstack/pull/8324#issuecomment-1844912934 > We create an extension of AutoScaleManagerImpl.java, override these 2 methods, and override the spring-server-core-managers-context.xml to set the value of the manager to our e

Re: [PR] Allow autoscale group and name override [cloudstack]

2023-12-06 Thread via GitHub
codecov[bot] commented on PR #8324: URL: https://github.com/apache/cloudstack/pull/8324#issuecomment-1843734766 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8324?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] Allow autoscale group and name override [cloudstack]

2023-12-06 Thread via GitHub
rg9975 commented on PR #8324: URL: https://github.com/apache/cloudstack/pull/8324#issuecomment-1843733421 We create an extension of AutoScaleManagerImpl.java, override these 2 methods, and override the spring-server-core-managers-context.xml to set the value of the manager to our extension

Re: [PR] Allow autoscale group and name override [cloudstack]

2023-12-06 Thread via GitHub
weizhouapache commented on PR #8324: URL: https://github.com/apache/cloudstack/pull/8324#issuecomment-1843725494 @rg9975 it is trivial indeed. can you give more details how you will use the method ? -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] Allow autoscale group and name override [cloudstack]

2023-12-06 Thread via GitHub
rg9975 opened a new pull request, #8324: URL: https://github.com/apache/cloudstack/pull/8324 … conventions ### Description Updates AutoScaleManager/AutoScaleManagerImpl so that getNextVmHostName and checkAutoScaleVmGroupName can be overridden in derivative implementations to allow