rohityadavcloud merged PR #8560:
URL: https://github.com/apache/cloudstack/pull/8560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
blueorangutan commented on PR #8560:
URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1909796357
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8560 (QA-JID-270)
--
This is an automated message from the Apache Git Service.
To respond t
blueorangutan commented on PR #8560:
URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1909776516
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep
you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond
DaanHoogland commented on PR #8560:
URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1909772147
retesting;
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kohrar commented on PR #8560:
URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1909652043
> > > @sureshanaparti this is based on main so I changed the milestone to
4.20. @kohrar if you wnat this in 4.18.2 please `git rebase --onto 4.18
` cc @JoaoJandre
> >
> >
>
github-actions[bot] commented on PR #8560:
URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1909639505
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache Gi
harikrishna-patnala commented on PR #8560:
URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1909425727
> > @sureshanaparti this is based on main so I changed the milestone to
4.20. @kohrar if you wnat this in 4.18.2 please `git rebase --onto 4.18
` cc @JoaoJandre
>
>
kohrar commented on PR #8560:
URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1908713400
> @sureshanaparti this is based on main so I changed the milestone to 4.20.
@kohrar if you wnat this in 4.18.2 please `git rebase --onto 4.18 ` cc @JoaoJandre
@DaanHoogland Thank
DaanHoogland commented on PR #8560:
URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1908341928
@sureshanaparti this is based on main so I changed the milestone to 4.20.
@kohrar if you wnat this in 4.18.2 please `git rebase --onto 4.18 `
cc @JoaoJandre
--
This is an
blueorangutan commented on PR #8560:
URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1908298787
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8560 (QA-JID-268)
--
This is an automated message from the Apache Git Service.
To respond t
blueorangutan commented on PR #8560:
URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1908267146
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep
you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond
DaanHoogland commented on PR #8560:
URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1908265633
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
shwstppr commented on PR #8560:
URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1907627264
@kohrar this needs to be targetted to 4.18 branch if you would want it to go
in 4.18.2 cc @JoaoJandre
--
This is an automated message from the Apache Git Service.
To respond to the
sureshanaparti commented on code in PR #8560:
URL: https://github.com/apache/cloudstack/pull/8560#discussion_r1464358972
##
ui/public/locales/en.json:
##
@@ -2534,6 +2534,7 @@
"message.adding.netscaler.provider": "Adding Netscaler provider",
"message.advanced.security.group":
codecov[bot] commented on PR #8560:
URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1907441465
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8560?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
sureshanaparti commented on code in PR #8560:
URL: https://github.com/apache/cloudstack/pull/8560#discussion_r1464350371
##
ui/public/locales/en.json:
##
@@ -2781,6 +2782,7 @@
"message.error.display.text": "Please enter display text.",
"message.error.duration.less.than.interva
kohrar opened a new pull request, #8560:
URL: https://github.com/apache/cloudstack/pull/8560
### Description
This PR fixes two missing English locale strings that are missing in the
metrics page in 4.18.1.
### Types of changes
- [ ] Breaking change (fix or feature that would
17 matches
Mail list logo
