Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-12-05 Thread via GitHub
weizhouapache merged PR #9394: URL: https://github.com/apache/cloudstack/pull/9394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@c

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-12-05 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2522251561 [SF] Trillian test result (tid-11859) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 56110 seconds Marvin logs: https://github.com/

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-12-05 Thread via GitHub
DaanHoogland commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2520456380 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-12-05 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2520461703 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-12-05 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2520199275 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-12-05 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2520041134 [SF] Trillian Build Failed (tid-11856) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-12-05 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2520018908 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-12-05 Thread via GitHub
DaanHoogland commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2520017266 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-12-05 Thread via GitHub
DaanHoogland commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2519919771 @FelipeM525 @JoaoJandre , I did not investigate deeply but systemVMs do not start in this env: ``` 2024-12-05 10:28:41,870 ERROR [c.c.v.VmWorkJobDispatcher] (Work-Job-Execut

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-12-04 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2517972490 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-12-04 Thread via GitHub
DaanHoogland commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2517971531 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-12-04 Thread via GitHub
DaanHoogland commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2516500250 > @DaanHoogland could we run the CI here? @JoaoJandre , our lab has been very busy the last few days. I'll have a go later tonight or in the weekend. -- This is an automa

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-12-02 Thread via GitHub
JoaoJandre commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2512547444 @DaanHoogland could we run the CI here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-11-29 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2507999699 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-11-29 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2507877209 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-11-29 Thread via GitHub
BryanMLima commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2507875544 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-09-11 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2343739830 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-09-11 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2343555901 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-09-11 Thread via GitHub
weizhouapache commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2343551092 > for the debian build I see > > ``` > 10:02:05 [ERROR] Failed to execute goal on project cloud-server: Could not resolve dependencies for project org.apache.cloudstack

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-09-11 Thread via GitHub
DaanHoogland commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2343041059 for the debian build I see ``` 10:02:05 [ERROR] Failed to execute goal on project cloud-server: Could not resolve dependencies for project org.apache.cloudstack:cloud-server

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-09-11 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2343025137 Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 11094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-09-11 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2342910875 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-09-11 Thread via GitHub
DaanHoogland commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2342907859 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-08-20 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2298380722 @DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-08-20 Thread via GitHub
DaanHoogland commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2298376282 @blueorangutan LLtest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-08-16 Thread via GitHub
FelipeM525 commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2293332316 @weizhouapache could you run tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-08-15 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2291356647 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-08-15 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2291236664 @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-08-15 Thread via GitHub
JoaoJandre commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2291233083 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2264816580 @FelipeM525 - `hostip` should be renamed to `hostIp` - `getHostip` and `setHostip` are not needed. there are already `getHostIp` and `setHostIp` -- This is an automa

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-08-01 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2264553578 [SF] Trillian test result (tid-11008) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 49272 seconds Marvin logs: https://github.co

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-08-01 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2263247530 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To re

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-08-01 Thread via GitHub
weizhouapache commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2263244201 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-08-01 Thread via GitHub
FelipeM525 commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2263205161 @weizhouapache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-07-18 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2236549486 [SF] Trillian Build Failed (tid-10909) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-07-18 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2236464077 @weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-07-18 Thread via GitHub
weizhouapache commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2236459447 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-07-18 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2236436309 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10397 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-07-18 Thread via GitHub
blueorangutan commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2236290866 @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-07-18 Thread via GitHub
JoaoJandre commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2236288969 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-07-16 Thread via GitHub
FelipeM525 commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2230881516 > good code @FelipeM525, but is there a cause for this? I mean is there a plan to exploit this ? Hello @DaanHoogland, Given the scope of Cloudstack and the number of people t

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-07-15 Thread via GitHub
weizhouapache commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2228876648 > good code @FelipeM525, but is there a cause for this? I mean is there a plan to exploit this ? I have same questions -- This is an automated message from the Apache Gi

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-07-15 Thread via GitHub
DaanHoogland commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2228772486 good code @FelipeM525, but is there a cause for this? I mean is there a plan to exploit this ? -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-07-15 Thread via GitHub
codecov[bot] commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2228559900 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9394?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] Add access modifier to `VolumeVO` [cloudstack]

2024-07-15 Thread via GitHub
FelipeM525 opened a new pull request, #9394: URL: https://github.com/apache/cloudstack/pull/9394 ### Description The class `VolumeVO` lacks access modifiers in its fields. This PR aims to improve adherence to object-oriented programming by adding private access modifiers to all field